Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zsh completion and docs #2194

Merged
merged 1 commit into from
Nov 16, 2017
Merged

Add zsh completion and docs #2194

merged 1 commit into from
Nov 16, 2017

Conversation

kenden
Copy link
Contributor

@kenden kenden commented Nov 14, 2017

Implement #1794

This is based on the zsh completion from kops, at kubernetes/kops#2406

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 14, 2017
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 14, 2017
@codecov-io
Copy link

Codecov Report

Merging #2194 into master will decrease coverage by 0.87%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2194      +/-   ##
==========================================
- Coverage   28.62%   27.75%   -0.88%     
==========================================
  Files          82       82              
  Lines        5369     5535     +166     
==========================================
- Hits         1537     1536       -1     
- Misses       3637     3803     +166     
- Partials      195      196       +1
Impacted Files Coverage Δ
cmd/minikube/cmd/completion.go 1.04% <0%> (-6.96%) ⬇️
pkg/util/kubeconfig/config.go 47.61% <0%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10f2bb5...97edb74. Read the comment docs.

Copy link
Contributor

@r2d4 r2d4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a zsh to test this against right now, but this overall LGTM and I'm sure some users will really appreciate it.

Copy link
Contributor

@r2d4 r2d4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@r2d4 r2d4 merged commit bbc40bd into kubernetes:master Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants