Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crio: update to v1.8.4 #2160

Closed
wants to merge 1 commit into from
Closed

Conversation

vbatts
Copy link
Contributor

@vbatts vbatts commented Nov 6, 2017

Also, this fixes the version output from kubectl describe node.
Now it shows:

[...]
System Info:
 Machine ID:                    41af387f4d4e4a3eabcdd2454a7e17f9
 System UUID:                   B5BA9F83-3476-4B4A-943A-81E7A3953234
 Boot ID:                       7e616123-fa50-4fa9-8f47-88b2a09fbb81
 Kernel Version:                4.9.13
 OS Image:                      Buildroot 2017.02
 Operating System:              linux
 Architecture:                  amd64
 Container Runtime Version:     cri-o://1.8.4
 Kubelet Version:               v1.8.0
 Kube-Proxy Version:            v1.8.0
[...]

Signed-off-by: Vincent Batts [email protected]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 6, 2017
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 6, 2017
@r2d4
Copy link
Contributor

r2d4 commented Nov 6, 2017

@minikube-bot ok to test

@codecov-io
Copy link

Codecov Report

Merging #2160 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2160   +/-   ##
======================================
  Coverage    28.6%   28.6%           
======================================
  Files          82      82           
  Lines        5369    5369           
======================================
  Hits         1536    1536           
  Misses       3637    3637           
  Partials      196     196

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f46b2fd...e60d93e. Read the comment docs.

@vbatts
Copy link
Contributor Author

vbatts commented Nov 9, 2017

crio-v1.0.3 is released now. I'm updating to it now.

Though i'm not sure what to say about some of these test failures.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 9, 2017
@vbatts vbatts changed the title crio: update to v1.0.2 crio: update to v1.0.3 Nov 9, 2017
@vbatts
Copy link
Contributor Author

vbatts commented Nov 9, 2017

updated

@r2d4
Copy link
Contributor

r2d4 commented Nov 16, 2017

@minikube-bot retest this please

@dlorenc
Copy link
Contributor

dlorenc commented Nov 20, 2017

Looks like a crio build error:

make[2]: Leaving directory '/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/build/crio-bin-v1.0.3'
>>> crio-bin v1.0.3 Building
GOPATH="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/build/crio-bin-v1.0.3/_output" PATH=/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/build/crio-bin-v1.0.3/_output/bin:"/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/bin:/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/sbin:/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin:/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/sbin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games:/usr/local/go/bin:/usr/local/go/bin:/usr/local/go/bin" /usr/bin/make -j9 PATH="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/bin:/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/sbin:/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin:/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/sbin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games:/usr/local/go/bin:/usr/local/go/bin:/usr/local/go/bin" AR="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin/x86_64-minikube-linux-gnu-ar" AS="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin/x86_64-minikube-linux-gnu-as" LD="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin/x86_64-minikube-linux-gnu-ld" NM="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin/x86_64-minikube-linux-gnu-nm" CC="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin/x86_64-minikube-linux-gnu-gcc" GCC="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin/x86_64-minikube-linux-gnu-gcc" CPP="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin/x86_64-minikube-linux-gnu-cpp" CXX="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin/x86_64-minikube-linux-gnu-g++" FC="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin/x86_64-minikube-linux-gnu-gfortran" F77="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin/x86_64-minikube-linux-gnu-gfortran" RANLIB="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin/x86_64-minikube-linux-gnu-ranlib" READELF="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin/x86_64-minikube-linux-gnu-readelf" STRIP="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin/x86_64-minikube-linux-gnu-strip" OBJCOPY="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin/x86_64-minikube-linux-gnu-objcopy" OBJDUMP="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin/x86_64-minikube-linux-gnu-objdump" AR_FOR_BUILD="/usr/bin/ar" AS_FOR_BUILD="/usr/bin/as" CC_FOR_BUILD="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin/ccache /usr/bin/gcc" GCC_FOR_BUILD="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin/ccache /usr/bin/gcc" CXX_FOR_BUILD="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin/ccache /usr/bin/g++" LD_FOR_BUILD="/usr/bin/ld" CPPFLAGS_FOR_BUILD="-I/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/include" CFLAGS_FOR_BUILD="-O2 -I/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/include" CXXFLAGS_FOR_BUILD="-O2 -I/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/include" LDFLAGS_FOR_BUILD="-L/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/lib -L/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/lib -Wl,-rpath,/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/lib" FCFLAGS_FOR_BUILD="" DEFAULT_ASSEMBLER="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin/x86_64-minikube-linux-gnu-as" DEFAULT_LINKER="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin/x86_64-minikube-linux-gnu-ld" CPPFLAGS="-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64" CFLAGS="-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os " CXXFLAGS="-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os " LDFLAGS="" FCFLAGS=" -Os " FFLAGS=" -Os " PKG_CONFIG="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin/pkg-config" STAGING_DIR="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/x86_64-minikube-linux-gnu/sysroot" INTLTOOL_PERL=/usr/bin/perl -C /var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/build/crio-bin-v1.0.3 binaries PREFIX=/usr BUILDTAGS="containers_image_ostree_stub" 
make[2]: Entering directory '/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/build/crio-bin-v1.0.3'
go build  -tags "containers_image_ostree_stub containers_image_ostree_stub" -o bin/crio github.com/kubernetes-incubator/cri-o/cmd/crio
/usr/bin/make -C conmon
/usr/bin/make -C pause
make[3]: Entering directory '/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/build/crio-bin-v1.0.3/pause'
/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin/x86_64-minikube-linux-gnu-gcc -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os  -std=c99 -Os -Wall -Wextra -static -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -c -o pause.o pause.c
make[3]: Entering directory '/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/build/crio-bin-v1.0.3/conmon'
/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin/x86_64-minikube-linux-gnu-gcc -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os  -std=c99 -Os -Wall -Wextra -I/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/x86_64-minikube-linux-gnu/sysroot/usr/include/glib-2.0 -I/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/x86_64-minikube-linux-gnu/sysroot/usr/lib/glib-2.0/include -I/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/x86_64-minikube-linux-gnu/sysroot/usr/include   -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -c -o conmon.o conmon.c
/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin/x86_64-minikube-linux-gnu-gcc -o ../bin/pause pause.o -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os  -std=c99 -Os -Wall -Wextra -static 
/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/bin/x86_64-minikube-linux-gnu-gcc -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os  -std=c99 -Os -Wall -Wextra -I/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/x86_64-minikube-linux-gnu/sysroot/usr/include/glib-2.0 -I/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/x86_64-minikube-linux-gnu/sysroot/usr/lib/glib-2.0/include -I/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/x86_64-minikube-linux-gnu/sysroot/usr/include   -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -c -o cmsg.o cmsg.c
/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/usr/lib/gcc/x86_64-minikube-linux-gnu/5.4.0/../../../../x86_64-minikube-linux-gnu/bin/ld: cannot open output file ../bin/pause: No such file or directory

Any idea where pause is supposed to come from? Do we need to install it on our CI slaves or should it be handled in the buildroot config?

@ijl
Copy link
Contributor

ijl commented Nov 22, 2017

Looks like a missing requirement for glib2 fixed in #2213.

@surajssd
Copy link
Member

surajssd commented Dec 3, 2017

Latest stable release of cri-o now is v1.8.3 https://github.com/kubernetes-incubator/cri-o/releases/tag/v1.8.3

@vbatts
Copy link
Contributor Author

vbatts commented Dec 3, 2017 via email

Also, this fixes the version output from `kubectl describe node`.
Now it shows:
```
[...]
System Info:
 Machine ID:                    41af387f4d4e4a3eabcdd2454a7e17f9
 System UUID:                   B5BA9F83-3476-4B4A-943A-81E7A3953234
 Boot ID:                       7e616123-fa50-4fa9-8f47-88b2a09fbb81
 Kernel Version:                4.9.13
 OS Image:                      Buildroot 2017.02
 Operating System:              linux
 Architecture:                  amd64
 Container Runtime Version:     cri-o://1.8.4
 Kubelet Version:               v1.8.0
 Kube-Proxy Version:            v1.8.0
[...]
```

Signed-off-by: Vincent Batts <[email protected]>
@vbatts vbatts changed the title crio: update to v1.0.3 crio: update to v1.8.4 Dec 11, 2017
@vbatts
Copy link
Contributor Author

vbatts commented Dec 11, 2017

switched to the cri-o 1.8 branch (corresponds to the k8s branching).
Once it's build is green'ish, PTAL

@mrunalp
Copy link

mrunalp commented Dec 11, 2017

👍

@ijl
Copy link
Contributor

ijl commented Dec 12, 2017

@vbatts I had a branch with your original commit cherry-picked and a few things updated to the latest. It fixes some issues still in the build here. #2311

@afbjorklund
Copy link
Collaborator

@vbatts : seems this already got fixed (25c7629), so can probably be closed now ?

@vbatts vbatts closed this Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants