ingress: Add support for tcp and udp services #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Can one of the admins verify this patch? |
|
@minikube-bot ok to test |
Codecov Report
@@ Coverage Diff @@
## master #2142 +/- ##
=======================================
Coverage 28.59% 28.59%
=======================================
Files 82 82
Lines 5372 5372
=======================================
Hits 1536 1536
Misses 3640 3640
Partials 196 196Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds awareness for TCP and UDP services.
We need this as a preparation to support KubeVirt on minikube (i.e. we need to export a SPICE proxy).