DOM_SHUTDOWN should return state.Running #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically, DOMAIN_SHUTDOWN just means that the VM is in the process of shutting down. We should still return state.Running so that we don't return from `minikube stop` before the domain is actually stopped. This should fix a few flakes.
k8s-ci-robot
added
the
size/S
Codecov Report
@@ Coverage Diff @@
## master #2109 +/- ##
=======================================
Coverage 28.86% 28.86%
=======================================
Files 81 81
Lines 5307 5307
=======================================
Hits 1532 1532
Misses 3582 3582
Partials 193 193Continue to review full report at Codecov.
|
dlorenc
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically, DOMAIN_SHUTDOWN just means that the VM is in the process
of shutting down. We should still return state.Running so that we
don't return from
minikube stopbefore the domain is actuallystopped. This should fix a few flakes.