Enable cache image for Windows #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/M
|
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #2000 +/- ##
==========================================
- Coverage 29.87% 29.69% -0.18%
==========================================
Files 77 77
Lines 4760 4842 +82
==========================================
+ Hits 1422 1438 +16
- Misses 3158 3218 +60
- Partials 180 186 +6
Continue to review full report at Codecov.
|
|
@minikube-bot ok to test |
r2d4
reviewed
Sep 25, 2017
| @@ -162,6 +189,18 @@ func getSrcRef(image string) (types.ImageReference, error) { | |||
| } | |||
|
|
|||
| func getDstRef(image, dst string) (types.ImageReference, error) { | |||
There was a problem hiding this comment.
Could you maybe add a few unit tests here for the new behavior?
There was a problem hiding this comment.
Ok. I will add the unit tests from now.
k8s-ci-robot
added
size/L
dlorenc
approved these changes
Oct 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the cache image feature disabled by PR /pull/1982.
Use the wmic command to change a drive letter to a volume name (
C:\ -> \\?\Volume{GUID}\).