-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sudo -n
if --interactive=false
#19531
Conversation
@@ -75,6 +76,7 @@ func UnblockBootpd() error { | |||
klog.Infof("%v may require a password: %v", c.Args, err) | |||
if !viper.GetBool("interactive") { | |||
klog.Warningf("%s requires a password, and --interactive=false", c.Args) | |||
c.Args = slices.Insert(c.Args, 1, "-n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for limitting it only for "interactive" to avoid Unintended Privilege Escalation like if the user has recently used sudo for a different purpose. This could pose a security risk if the script is compromised or contains errors.
but it makes sense for not interactive
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 51.4s 51.0s 48.7s 50.2s 47.3s Times for minikube ingress: 16.0s 16.1s 15.0s 15.1s 15.0s docker driver with docker runtime
Times for minikube start: 21.0s 23.8s 21.4s 21.3s 21.6s Times for minikube ingress: 13.8s 13.3s 12.3s 10.9s 12.3s docker driver with containerd runtime
Times for minikube start: 23.7s 23.1s 20.1s 19.7s 22.5s Times for minikube ingress: 38.8s 38.8s 38.8s 33.3s 38.8s |
Here are the number of top 10 failed tests in each environments with lowest flake rate.
Besides the following environments also have failed tests:
To see the flake rates of all tests by environment, click here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #19518
Uses
sudo -n
if--interactive=false
Also changed the wording from
Your firewall is blocking bootpd which is required for socket_vmnet.
toYour firewall is blocking bootpd which is required for this configuration.
since vfkit also uses this logic.