Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use os.Chmod instead of File.Chmod #1933

Merged
merged 1 commit into from
Sep 11, 2017
Merged

Conversation

r2d4
Copy link
Contributor

@r2d4 r2d4 commented Sep 8, 2017

os.Chmod is cross platform, while File.Chmod seems not to be.

os.Chmod is cross platform, while File.Chmod seems not to be.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 8, 2017
@r2d4
Copy link
Contributor Author

r2d4 commented Sep 8, 2017

Fixes #1928

@codecov-io
Copy link

Codecov Report

Merging #1933 into master will increase coverage by 0.75%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1933      +/-   ##
==========================================
+ Coverage   30.62%   31.38%   +0.75%     
==========================================
  Files          75       75              
  Lines        4513     4557      +44     
==========================================
+ Hits         1382     1430      +48     
+ Misses       2950     2948       -2     
+ Partials      181      179       -2
Impacted Files Coverage Δ
pkg/minikube/bootstrapper/exec_runner.go 0% <0%> (ø) ⬆️
cmd/minikube/cmd/config/configure.go 1.73% <0%> (-0.05%) ⬇️
pkg/util/kubeconfig/config.go 47.61% <0%> (+0.68%) ⬆️
pkg/minikube/bootstrapper/certs.go 85.6% <0%> (+14.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f022a68...f8c1651. Read the comment docs.

@r2d4 r2d4 merged commit ad8ea13 into kubernetes:master Sep 11, 2017
@r2d4 r2d4 deleted the windows-fix branch September 11, 2017 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants