Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISO: enable CONFIG_EXT4_FS_SECURITY in arm64 #18779

Merged
merged 2 commits into from
May 1, 2024

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Apr 30, 2024

Fixes #18738

Before:

$ minikube start --driver qemu
...
$ minikube addons enable ingress
...
$ kubectl get pods -A
NAMESPACE       NAME                                        READY   STATUS             RESTARTS      AGE
ingress-nginx   ingress-nginx-admission-create-lntsx        0/1     Completed          0             51s
ingress-nginx   ingress-nginx-admission-patch-54kvv         0/1     Completed          0             51s
ingress-nginx   ingress-nginx-controller-768f948f8f-tzrpd   0/1     ImagePullBackOff   0             51s

After:

$ minikube start --driver qemu
...
$ minikube addons enable ingress
...
$ kubectl get pods -A
NAMESPACE       NAME                                        READY   STATUS      RESTARTS   AGE
ingress-nginx   ingress-nginx-admission-create-rq64x        0/1     Completed   0          22s
ingress-nginx   ingress-nginx-admission-patch-p8nnn         0/1     Completed   0          22s
ingress-nginx   ingress-nginx-controller-768f948f8f-w5vng   0/1     Running     0          22s

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 30, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2024
@spowelljr
Copy link
Member Author

ok-to-build-iso

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 30, 2024
@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 1, 2024
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18779) |
+----------------+----------+---------------------+
| minikube start | 51.7s    | 51.5s               |
| enable ingress | 26.6s    | 27.0s               |
+----------------+----------+---------------------+

Times for minikube start: 52.2s 51.0s 51.1s 50.3s 53.9s
Times for minikube (PR 18779) start: 51.3s 53.6s 51.7s 50.3s 50.7s

Times for minikube (PR 18779) ingress: 27.9s 27.0s 24.0s 28.0s 28.0s
Times for minikube ingress: 26.0s 27.5s 26.0s 28.5s 25.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18779) |
+----------------+----------+---------------------+
| minikube start | 22.4s    | 22.7s               |
| enable ingress | 21.7s    | 21.2s               |
+----------------+----------+---------------------+

Times for minikube (PR 18779) ingress: 19.3s 21.8s 21.8s 21.7s 21.3s
Times for minikube ingress: 21.8s 21.8s 21.3s 21.8s 21.8s

Times for minikube start: 20.9s 24.6s 21.1s 21.3s 23.9s
Times for minikube (PR 18779) start: 21.3s 24.2s 22.9s 20.3s 25.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18779) |
+----------------+----------+---------------------+
| minikube start | 22.5s    | 22.0s               |
| enable ingress | 38.3s    | 30.1s               |
+----------------+----------+---------------------+

Times for minikube start: 22.9s 22.8s 22.5s 20.4s 23.6s
Times for minikube (PR 18779) start: 20.1s 23.2s 21.8s 22.3s 22.7s

Times for minikube ingress: 31.8s 47.8s 31.8s 48.3s 31.8s
Times for minikube (PR 18779) ingress: 21.3s 32.8s 32.8s 31.8s 31.8s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_containerd TestFunctional/parallel/MountCmd/any-port (gopogh) 0.00 (chart)
KVM_Linux_containerd TestFunctional/parallel/MySQL (gopogh) 0.00 (chart)
KVM_Linux_containerd TestFunctional/parallel/NodeLabels (gopogh) 0.00 (chart)
KVM_Linux_containerd TestFunctional/parallel/ServiceCmdConnect (gopogh) 0.00 (chart)
KVM_Linux_containerd TestFunctional/parallel/ServiceCmd/DeployApp (gopogh) 0.00 (chart)
KVM_Linux_containerd TestFunctional/parallel/ServiceCmd/Format (gopogh) 0.00 (chart)
KVM_Linux_containerd TestFunctional/parallel/ServiceCmd/HTTPS (gopogh) 0.00 (chart)
KVM_Linux_containerd TestFunctional/parallel/ServiceCmd/JSONOutput (gopogh) 0.00 (chart)
KVM_Linux_containerd TestFunctional/parallel/ServiceCmd/List (gopogh) 0.00 (chart)
KVM_Linux_containerd TestFunctional/parallel/ServiceCmd/URL (gopogh) 0.00 (chart)
KVM_Linux_containerd TestFunctional/parallel/StatusCmd (gopogh) 0.00 (chart)
KVM_Linux_containerd TestFunctional/serial/InvalidService (gopogh) 0.00 (chart)
KVM_Linux_containerd TestFunctional/parallel/DashboardCmd (gopogh) 0.67 (chart)
KVM_Linux_crio TestAddons/parallel/LocalPath (gopogh) 1.65 (chart)
KVM_Linux_crio TestFunctional/parallel/ImageCommands/ImageRemove (gopogh) 4.03 (chart)
Docker_Windows TestOffline (gopogh) 5.22 (chart)
Docker_macOS TestMountStart/serial/VerifyMountFirst (gopogh) 8.55 (chart)
Docker_Windows TestForceSystemdFlag (gopogh) 8.70 (chart)
Docker_Linux_crio TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 12.00 (chart)
Hyper-V_Windows TestPause/serial/SecondStartNoReconfiguration (gopogh) 12.35 (chart)
Hyper-V_Windows TestMultiControlPlane/serial/StopSecondaryNode (gopogh) 14.00 (chart)
Hyper-V_Windows TestMultiControlPlane/serial/AddWorkerNode (gopogh) 17.12 (chart)
Hyper-V_Windows TestMultiControlPlane/serial/CopyFile (gopogh) 20.91 (chart)
Hyperkit_macOS TestErrorSpam/setup (gopogh) 21.00 (chart)
Hyper-V_Windows TestPreload (gopogh) 22.52 (chart)
Hyper-V_Windows TestKubernetesUpgrade (gopogh) 22.92 (chart)
Docker_macOS TestCertOptions (gopogh) 23.21 (chart)
Docker_macOS TestDockerFlags (gopogh) 23.89 (chart)
Docker_macOS TestForceSystemdEnv (gopogh) 23.89 (chart)
Docker_macOS TestForceSystemdFlag (gopogh) 23.89 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit f1e27bb into kubernetes:master May 1, 2024
27 of 41 checks passed
@spowelljr spowelljr deleted the addFSSecurityArm64 branch May 1, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minikube addons enable ingress fails on Minikube v1.33.0
5 participants