Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon gvisor: Add building arm64 image #18453

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

spowelljr
Copy link
Member

make push-gvisor-addon-image now builds for amd64 & arm64

Also changed the image tag to match the same format as the rest of the images, 4 -> v0.0.1

New build also fixes many CVES:

Before:

16 vulnerabilities found in 3 packages
  UNSPECIFIED  1   
  LOW          0   
  MEDIUM       12  
  HIGH         2   
  CRITICAL     1   

After:

  No vulnerable packages detected

@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Mar 19, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 19, 2024
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 18453) |
+-------------------+----------+---------------------+
| ⚠️  minikube start | 51.4s    | 73.2s ⚠️             |
| enable ingress    | 24.8s    | 26.6s               |
+-------------------+----------+---------------------+

Times for minikube start: 53.2s 51.6s 51.2s 52.0s 49.0s
Times for minikube (PR 18453) start: 50.8s 162.9s 50.4s 52.3s 49.5s

Times for minikube ingress: 27.5s 23.5s 24.6s 24.5s 24.0s
Times for minikube (PR 18453) ingress: 26.1s 24.1s 28.0s 28.5s 26.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18453) |
+----------------+----------+---------------------+
| minikube start | 23.8s    | 22.0s               |
| enable ingress | 21.2s    | 21.2s               |
+----------------+----------+---------------------+

Times for minikube start: 24.4s 23.9s 21.5s 24.7s 24.3s
Times for minikube (PR 18453) start: 20.8s 22.0s 21.8s 21.5s 24.0s

Times for minikube (PR 18453) ingress: 21.3s 20.8s 21.3s 21.3s 21.3s
Times for minikube ingress: 20.8s 21.8s 21.8s 20.8s 20.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18453) |
+----------------+----------+---------------------+
| minikube start | 20.7s    | 20.5s               |
| enable ingress | 34.9s    | 29.2s               |
+----------------+----------+---------------------+

Times for minikube (PR 18453) ingress: 31.8s 31.8s 18.8s 31.8s 31.8s
Times for minikube ingress: 30.3s 32.8s 31.8s 31.8s 47.8s

Times for minikube start: 20.8s 22.5s 20.3s 19.9s 20.0s
Times for minikube (PR 18453) start: 23.6s 20.2s 18.9s 20.4s 19.6s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_crio TestMultiControlPlane/serial/RestartCluster (gopogh) 0.00 (chart)
KVM_Linux_containerd TestNoKubernetes/serial/StartNoArgs (gopogh) 0.59 (chart)
Docker_macOS TestMountStart/serial/VerifyMountFirst (gopogh) 6.10 (chart)
KVM_Linux_crio TestFunctional/parallel/PersistentVolumeClaim (gopogh) 6.47 (chart)
Docker_macOS TestCertOptions (gopogh) 9.86 (chart)
Docker_macOS TestForceSystemdFlag (gopogh) 11.11 (chart)
Docker_macOS TestDockerFlags (gopogh) 13.51 (chart)
Docker_macOS TestForceSystemdEnv (gopogh) 14.67 (chart)
Docker_macOS TestInsufficientStorage (gopogh) 21.95 (chart)
Docker_macOS TestMultiNode/serial/AddNode (gopogh) 21.95 (chart)
Docker_macOS TestMultiNode/serial/CopyFile (gopogh) 21.95 (chart)
Docker_macOS TestMultiNode/serial/DeleteNode (gopogh) 21.95 (chart)
Docker_macOS TestMultiNode/serial/DeployApp2Nodes (gopogh) 21.95 (chart)
Docker_macOS TestMultiNode/serial/FreshStart2Nodes (gopogh) 21.95 (chart)
Docker_macOS TestMultiNode/serial/MultiNodeLabels (gopogh) 21.95 (chart)
Docker_macOS TestMultiNode/serial/PingHostFrom2Pods (gopogh) 21.95 (chart)
Docker_macOS TestMultiNode/serial/ProfileList (gopogh) 21.95 (chart)
Docker_macOS TestMultiNode/serial/RestartKeepsNodes (gopogh) 21.95 (chart)
Docker_macOS TestMultiNode/serial/RestartMultiNode (gopogh) 21.95 (chart)
Docker_macOS TestMultiNode/serial/StartAfterStop (gopogh) 21.95 (chart)
Docker_macOS TestMultiNode/serial/StopMultiNode (gopogh) 21.95 (chart)
Docker_macOS TestMultiNode/serial/StopNode (gopogh) 21.95 (chart)
Docker_macOS TestOffline (gopogh) 21.95 (chart)
Docker_macOS TestScheduledStopUnix (gopogh) 21.95 (chart)
Hyperkit_macOS TestErrorSpam/setup (gopogh) 33.33 (chart)
Hyperkit_macOS TestCertExpiration (gopogh) 36.67 (chart)
Hyperkit_macOS TestFunctional/parallel/CpCmd (gopogh) 36.67 (chart)
Hyperkit_macOS TestFunctional/parallel/SSHCmd (gopogh) 36.67 (chart)
Hyperkit_macOS TestFunctional/serial/CacheCmd/cache/cache_reload (gopogh) 36.67 (chart)
Hyperkit_macOS TestFunctional/serial/CacheCmd/cache/verify_cache_inside_node (gopogh) 36.67 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh
Copy link
Member

medyagh commented Mar 20, 2024

/lgtm

@medyagh medyagh merged commit 137c5ef into kubernetes:master Mar 20, 2024
35 of 50 checks passed
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr deleted the buildMultiarchGvisor branch March 20, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants