-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Cilium to v1.15.1 for k8s 1.28 compatibility #18259
Conversation
|
Welcome @camclay! |
Hi @camclay. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
I setup the Easy CLA and amended the commit, but please let me know if I need to resubmit this PR. Thanks in advance! |
@camclay It looks like the commit you pushed with isn't linked to your GitHub, could you try amending the commit with an email tied to your GitHub? |
I got this configured! Had my github email set to private, amended and linked now! Thank you! |
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 48.1s 49.5s 50.5s 53.2s 50.1s Times for minikube ingress: 24.6s 23.0s 24.1s 27.0s 26.7s docker driver with docker runtime
Times for minikube start: 25.3s 24.9s 21.2s 25.2s 22.2s Times for minikube ingress: 20.9s 22.9s 24.8s 20.8s 21.8s docker driver with containerd runtime
Times for minikube start: 20.5s 23.5s 24.4s 23.9s 20.5s Times for minikube (PR 18259) ingress: 30.3s 32.3s 31.3s 31.3s 31.3s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for this PR @camclay, look forward to see more contributions from you
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camclay, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Context
The Cilium version deployed by minikube is incompatible with version 1.28 of Kubernetes and is no longer supported by the Cilium project.
This PR updates Cilium to version 1.15.1, the latest available.
Implementation
Update Kubernetes template in minikube/pkg/cni/cilium.go to version 1.15.1 in the image sections. No significant changes were needed in the template which are breaking at this time.
Testing
Limited testing was done, on a Mac M1, using Docker v4.27.2 and minikube v1.32.0.
Note This was heavily based off the earlier commit by @rastaman in #15242