kvm2 driver: Remove uneeded nvram element #18241
Conversation
The curent domain xml template includes static nvram image using the
shared template image:
<nvram>/usr/share/AAVMF/AAVMF_VARS.fd</nvram>
This "works" when starting sinlge profile, but when starting a second
profile this breaks with:
virError(Code=55, Domain=24, Message='Requested operation is not
valid: Setting different SELinux label on /usr/share/AAVMF/AAVMF_VARS.fd
which is already in use
Which tells us that we are doing the wrong thing.
If we remove the nvram element, a new per-vm nvram is created
dynamially:
$ virsh -c qemu:///system dumpxml ex1 | grep nvram
<nvram template='/usr/share/AAVMF/AAVMF_VARS.fd'>/var/lib/libvirt/qemu/nvram/ex1_VARS.fd</nvram>
$ virsh -c qemu:///system dumpxml ex2 | grep nvram
<nvram template='/usr/share/AAVMF/AAVMF_VARS.fd'>/var/lib/libvirt/qemu/nvram/ex2_VARS.fd</nvram>
k8s-ci-robot
added
cncf-cla: yes
|
Hi @nirs. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/XS
|
Can one of the admins verify this patch? |
Build and installStart the first clusterStart the second clusterEach VM get it's own nvrame imageIssuesthe nvram image is not removed when deleting the minikube cluster. Not sure if |
k8s-ci-robot
added
the
approved
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
kvm2 driver with docker runtime Times for minikube start: 164.2s 53.1s 50.4s 51.9s 48.5s Times for minikube ingress: 25.1s 22.7s 27.7s 25.7s 25.7s docker driver with docker runtime Times for minikube start: 25.5s 26.3s 24.7s 26.1s 21.9s Times for minikube (PR 18241) ingress: 20.4s 20.3s 21.3s 22.3s 20.3s docker driver with containerd runtime Times for minikube start: 24.1s 24.2s 22.0s 21.1s 21.3s Times for minikube (PR 18241) ingress: 30.8s 30.9s 29.8s 46.8s 30.9s |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
|
@afbjorklund HyperKit and QEMU failures should be unrelated since the change is in libvirt configuration domain xml. Are these tests broken now? |
|
thank you for this contribution @nirs |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, BlaineEXE, medyagh, nirs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The curent domain xml template includes static nvram image using the shared template image:
This "works" when starting sinlge profile, but when starting a second profile this breaks with:
Which tells us that we are doing the wrong thing.
If we remove the nvram element, a new per-vm nvram is created dynamially:
Tested on top of #18239
Fixes #18240