-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minikube-iso: set CONFIG_QFMT_V2=y for aarch64 #17991
Conversation
Welcome @zjx20! |
Hi @zjx20. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
f48a2ea
to
74cc95f
Compare
ok-to-build-iso |
Hi @zjx20, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 53.1s 51.0s 56.1s 56.0s 52.0s Times for minikube ingress: 25.6s 22.7s 27.0s 26.6s 24.0s docker driver with docker runtime
Times for minikube (PR 17991) start: 25.5s 23.2s 21.9s 23.1s 24.6s Times for minikube ingress: 20.3s 22.9s 20.3s 21.4s 20.3s docker driver with containerd runtime
Times for minikube start: 21.2s 21.0s 21.2s 23.7s 22.0s Times for minikube ingress: 47.8s 30.8s 31.8s 29.8s 46.8s |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spowelljr, zjx20 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
If the option
CONFIG_QFMT_V2=y
is not set, the kernel prompts an error when attempting to use the project quota feature of ext4 in a minikube VM or minikube k8s cluster:The reproduction steps are as follows:
Then check
dmesg
and you will see the error message mentioned earlier:Please also notice that this option has been enabled in the x86_64 image:
minikube/deploy/iso/minikube-iso/board/minikube/x86_64/linux_x86_64_defconfig
Line 491 in 5af9a51