addons: Fix auto-pause addon #17866
addons: Fix auto-pause addon #17866
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
ok-to-build-iso |
|
ok-to-build-image |
|
Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further. |
|
ok-to-build-iso |
spowelljr
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
After unpausing the pods |
spowelljr
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
ok-to-build-image |
|
Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further. |
|
Hi @spowelljr, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This comment has been minimized.
This comment has been minimized.
spowelljr
force-pushed
the
fixAutoPause
branch
from
8c6a2e9
to
c113a26
Compare
|
ok-to-build-image |
|
Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further. |
This comment has been minimized.
This comment has been minimized.
|
kvm2 driver with docker runtime Times for minikube ingress: 27.2s 28.7s 27.2s 24.3s 26.2s Times for minikube start: 50.4s 51.2s 49.2s 54.7s 50.7s docker driver with docker runtime Times for minikube ingress: 21.8s 20.9s 20.9s 20.4s 20.4s Times for minikube start: 22.8s 25.0s 21.9s 25.3s 25.7s docker driver with containerd runtime Times for minikube start: 24.7s 23.6s 24.7s 24.6s 23.4s Times for minikube ingress: 31.4s 31.4s 30.4s 31.4s 31.4s |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
Reverting #11909 and #17070 as they both caused issues related to the auto-pause addon.
Starting with #17070, the PR added calling
viper.GetString(config.ProfileName)incmd/auto-pause/auto-pause.go. The problem iscmd/auto-pause/auto-pause.gois built and then ran inside the Kicbase/ISO, somustload.Partial(profile)always fails since we're inside the Kicbase/ISO and there is no~/.minikubefolder, causing the the auto-pause binary to exit and breaking the addon andkubectlcommands.I'm not sure the exact cause of the failure related to #11909 (will revisit once addon is back in a working state) but after the pods are unpaused
kubectlcommands hang for a while until finally responding withUnable to connect to the server: EOF.I also updated the auto-pause addon image since
v0.0.4was only built for arm64 so other architectures fail with an exec error.Before:
After updating auto-pause image:
After updating auto-pause image and reverting #17070
After updating auto-pause image and reverting #17070 & #11909