Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kicbase: Fix modifying Docker binfmt config #17830

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

spowelljr
Copy link
Member

Fixes #17700

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 18, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2023
@spowelljr
Copy link
Member Author

ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member Author

ok-to-build-image

1 similar comment
@spowelljr
Copy link
Member Author

ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 20, 2023
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr
Copy link
Member Author

ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17830) |
+----------------+----------+---------------------+
| minikube start | 51.0s    | 50.3s               |
| enable ingress | 27.5s    | 26.7s               |
+----------------+----------+---------------------+

Times for minikube start: 49.9s 50.3s 49.5s 54.7s 50.3s
Times for minikube (PR 17830) start: 50.0s 51.7s 49.2s 50.3s 50.2s

Times for minikube ingress: 27.7s 26.7s 28.6s 27.2s 27.2s
Times for minikube (PR 17830) ingress: 27.6s 26.6s 28.1s 27.2s 24.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17830) |
+----------------+----------+---------------------+
| minikube start | 23.9s    | 23.1s               |
| enable ingress | 20.2s    | 19.7s               |
+----------------+----------+---------------------+

Times for minikube start: 24.0s 24.0s 24.9s 24.3s 22.3s
Times for minikube (PR 17830) start: 22.7s 21.9s 24.1s 24.9s 21.7s

Times for minikube ingress: 19.8s 20.8s 20.8s 18.8s 20.8s
Times for minikube (PR 17830) ingress: 20.8s 20.8s 18.8s 19.8s 18.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17830) |
+----------------+----------+---------------------+
| minikube start | 21.8s    | 22.4s               |
| enable ingress | 28.1s    | 31.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 30.3s 30.3s 31.3s 18.3s 30.3s
Times for minikube (PR 17830) ingress: 31.3s 46.3s 32.3s 18.3s 30.3s

Times for minikube start: 23.5s 23.8s 20.9s 20.6s 20.0s
Times for minikube (PR 17830) start: 22.8s 23.3s 24.2s 20.6s 21.0s

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2024
@spowelljr spowelljr merged commit 49595dc into kubernetes:master Jan 9, 2024
25 of 38 checks passed
@spowelljr spowelljr deleted the fixBinFmt branch January 9, 2024 00:06
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_crio_arm64 TestMissingContainerUpgrade (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestMultiNode/serial/PingHostFrom2Pods (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestRunningBinaryUpgrade (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestStoppedBinaryUpgrade/Upgrade (gopogh) 0.00 (chart)
Docker_Linux_crio TestMultiNode/serial/PingHostFrom2Pods (gopogh) 0.00 (chart)
Docker_Linux_crio TestRunningBinaryUpgrade (gopogh) 0.00 (chart)
Docker_Linux_crio TestStoppedBinaryUpgrade/Upgrade (gopogh) 0.00 (chart)
Docker_macOS TestMountStart/serial/StartWithMountSecond (gopogh) 0.00 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/Pause (gopogh) 0.00 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 0.00 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 0.00 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/VerifyKubernetesImages (gopogh) 0.00 (chart)
Hyper-V_Windows TestNetworkPlugins/group/custom-flannel/NetCatPod (gopogh) 0.00 (chart)
Hyper-V_Windows TestRunningBinaryUpgrade (gopogh) 0.00 (chart)
Hyper-V_Windows TestStoppedBinaryUpgrade/Upgrade (gopogh) 0.00 (chart)
KVM_Linux_crio TestMultiNode/serial/PingHostFrom2Pods (gopogh) 0.00 (chart)
KVM_Linux_crio TestRunningBinaryUpgrade (gopogh) 0.00 (chart)
KVM_Linux_crio TestStoppedBinaryUpgrade/Upgrade (gopogh) 0.00 (chart)
QEMU_macOS TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 0.00 (chart)
QEMU_macOS TestStoppedBinaryUpgrade/Setup (gopogh) 0.00 (chart)
KVM_Linux_containerd TestAddons/parallel/NvidiaDevicePlugin (gopogh) 2.90 (chart)
KVM_Linux_crio TestAddons/parallel/Registry (gopogh) 3.55 (chart)
Docker_Linux_crio_arm64 TestScheduledStopUnix (gopogh) 8.51 (chart)
Docker_Linux_crio TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 9.09 (chart)
Hyper-V_Windows TestFunctional/parallel/ServiceCmd/Format (gopogh) 9.52 (chart)
Hyper-V_Windows TestFunctional/parallel/ServiceCmd/HTTPS (gopogh) 9.52 (chart)
Hyper-V_Windows TestFunctional/parallel/ServiceCmd/URL (gopogh) 9.52 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 28.57 (chart)

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting Minikube messes up binfmt config for Docker, making it unable to run cross-architecture images
5 participants