Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use etcd embed package, switch apiserver to use etcdv3 #1720

Merged
merged 2 commits into from
Jul 26, 2017

Conversation

r2d4
Copy link
Contributor

@r2d4 r2d4 commented Jul 20, 2017

Etcd's embed package does a lot of the heavy lifting we were doing previously, as well as configure etcd v3 endpoints.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 20, 2017
@codecov-io
Copy link

Codecov Report

Merging #1720 into master will increase coverage by 0.54%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1720      +/-   ##
==========================================
+ Coverage   36.23%   36.78%   +0.54%     
==========================================
  Files          51       51              
  Lines        3367     3317      -50     
==========================================
  Hits         1220     1220              
+ Misses       1966     1916      -50     
  Partials      181      181
Impacted Files Coverage Δ
pkg/localkube/etcd.go 0% <0%> (ø) ⬆️
pkg/localkube/apiserver.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c98ac20...a682bbb. Read the comment docs.

@r2d4
Copy link
Contributor Author

r2d4 commented Jul 20, 2017

Fixes #1254

@dlorenc
Copy link
Contributor

dlorenc commented Jul 21, 2017

Can you verify that an in-place upgrade works? Basically start minikube without this, deploy a bunch of stuff, then do a minikube start with this.

@r2d4
Copy link
Contributor Author

r2d4 commented Jul 21, 2017

I will try, but I don't think it will work. The upgrade from 1.6 to 1.7 won't work without a recreate either. I'm not sure exactly what we can do to support this sort of stuff.

@r2d4
Copy link
Contributor Author

r2d4 commented Jul 21, 2017

Well, I was wrong in both cases. It should work upgrading from 1.6.x => 1.7.0 and etcd2 => etcd3.

minikube start --kubernetes-version v1.6.4
minikube stop
minikube start --kubernetes-version v1.7.0

Copy link
Contributor

@dlorenc dlorenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's get a release with 1.7 out before we merge.

@r2d4 r2d4 merged commit 45eabf6 into kubernetes:master Jul 26, 2017
@r2d4 r2d4 deleted the etcd3 branch July 26, 2017 20:42
@r2d4 r2d4 mentioned this pull request Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants