cmd/minikube: delete accept no arguments

[darkowlzz]

This changeset makes it necessary to pass a profile/machine name in order
to delete. This would help avoid accidental deletion of machine by just
delete command.

Fixes #1683

[minikube-bot]

Can one of the admins verify this patch?

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[codecov-io]

Codecov Report

Merging #1718 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1718      +/-   ##
==========================================
+ Coverage   36.23%   36.25%   +0.01%     
==========================================
  Files          51       51              
  Lines        3367     3371       +4     
==========================================
+ Hits         1220     1222       +2     
- Misses       1966     1969       +3     
+ Partials      181      180       -1

Impacted Files	Coverage Δ
cmd/minikube/cmd/delete.go	8.33% <0%> (-1.67%)	⬇️
pkg/util/kubeconfig/config.go	46.85% <0%> (+1.39%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f32754f...17ba029. Read the comment docs.

[darkowlzz]

Bump to verify CLA

[darkowlzz]

oops! This isn't ready. Doesn't accepts the argument as profile. Fixing... 😅

Ready 👍

[r2d4]

@minikube-bot ok to test

[darkowlzz]

Some help with the failing test?
The test times out after 30 minutes. I'm not sure what's causing that. The delete command after the test seems to work and delete the vm.

[r2d4]

I don't think we want to break the default minikube delete case.

As a fix for #1683, I think we should just make sure to error on unknown arguments after command, rather than silently ignore them. i.e., $ minikube delete arg1 arg2 should fail, since we shouldn't ignore unknown arguments

As far as profiles go, each command accepts the --profile flag.

$ minikube delete, should work and delete the default machine
$ minikube delete --profile vm2 should delete the minikube profile vm2

I'm not a huge fan of moving the profile flag behavior to an optional noun after minikube <start, stop, delete> since we'd probably have to have every command behave that way. Sorry if my original comment on the issue was unclear,

minikube delete either takes no args or just the machine name

I think it really can't take the machine name without a pretty big change to the UX (since all commands should behave similarly.) But the enforcing the former (no unknown args) is definitely something we should do.

Let me know if that makes sense

[darkowlzz]

Yep, that makes sense. Consistency among the commands :)
I have updated the PR and made delete not accept any argument.

[darkowlzz]

Failing again 🤷‍♀️

[r2d4]

Thanks for working through the feedback! And thanks for the PR!

[javajon]

As the original requester for #1683 it is great to see this enhancement added. Thanks all.