Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do dockerized builds for minikube and localkube #1656

Merged
merged 2 commits into from
Jun 29, 2017
Merged

Do dockerized builds for minikube and localkube #1656

merged 2 commits into from
Jun 29, 2017

Commits on Jun 29, 2017

  1. Add option to build minikube, localkube in docker 

    BUILD_IN_DOCKER=y will build both localkube and minikube in docker
LOCALKUBE_BUILD_IN_DOCKER=y, MINIKUBE_BUILD_IN_DOCKER=y will toggle
docker builds for each respective binary

Regardless of the options provided, if you attempt to build localkube on
a non-linux platform, it will run in docker.  This ensures that `make`
still works as expected on darwin.
    @r2d4
    r2d4 committed Jun 29, 2017
    Configuration menu
    Copy the full SHA
    3ffc1e7 View commit details
    Browse the repository at this point in the history

  2. Switch cross builds to use BUILD_IN_DOCKER 

    minikube-linux-amd64 and minikube-darwin-amd64 cannot be cross built
natively on different platforms and must be built in the container.
    @r2d4
    r2d4 committed Jun 29, 2017
    Configuration menu
    Copy the full SHA
    f998882 View commit details
    Browse the repository at this point in the history