Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PowerShell code completion #16232

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Add PowerShell code completion #16232

merged 1 commit into from
Apr 7, 2023

Conversation

oldium
Copy link
Contributor

@oldium oldium commented Apr 4, 2023 •
edited
Loading

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 4, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @oldium. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 4, 2023
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

spowelljr
spowelljr requested changes Apr 4, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@oldium
Copy link
Contributor Author

oldium commented Apr 4, 2023

The build error in GitHub CI/CD pipeline is caused by checksum problem in gopogh v0.15.0 package.

@oldium oldium mentioned this pull request Apr 4, 2023
Closed
@spowelljr
Copy link
Member

The build error in GitHub CI/CD pipeline is caused by checksum problem in gopogh v0.15.0 package.

The gopogh version was bumped and merged, could you rebase

#16234

@oldium
Copy link
Contributor Author

oldium commented Apr 5, 2023

Rebased

@spowelljr spowelljr mentioned this pull request Apr 7, 2023
Closed
@oldium
Copy link
Contributor Author

oldium commented Apr 7, 2023 •
edited
Loading

On another note, if you @spowelljr have some time, please - I am also trying to get my other PR merged to fix the --profile to --cluster argument translation in minikube kubectl __complete command-line-completion call. The last one looking at it (I also pointed him to my PR aftewards) was Ben Krieger with his PR, which unfortunately completely removed the --cluster argument from the command-line-completion call, so the suggestions might not match the actual kubectl call.

spowelljr
spowelljr requested changes Apr 7, 2023
View reviewed changes
cmd/minikube/cmd/completion.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 7, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 7, 2023
@oldium
Copy link
Contributor Author

oldium commented Apr 7, 2023

Updated to use single-quotes, which is more readable.

spowelljr
spowelljr requested changes Apr 7, 2023
View reviewed changes
Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run make generate-docs to update all the docs and push the changes up

@oldium
Add PowerShell code completion
4a86882 
Signed-off-by: Oldřich Jedlička <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 7, 2023
@oldium
Copy link
Contributor Author

oldium commented Apr 7, 2023

Done

spowelljr
spowelljr approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'll don't know a ton about auto completion but I'll take a look at our other PR on Monday.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oldium, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2023
@spowelljr spowelljr merged commit 190f01a into kubernetes:master Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spowelljr spowelljr spowelljr approved these changes

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oldium @k8s-ci-robot @minikube-bot @spowelljr