Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cruntime/docker: Include system logs from cri-docker #16149

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

maxbrunet
Copy link
Contributor

It should be a safe change and help with troubleshooting. journalctl does not error if no matching units exist.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 24, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @maxbrunet. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 24, 2023
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@afbjorklund
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 24, 2023
@afbjorklund

This comment was marked as outdated.

@afbjorklund
Copy link
Collaborator

/hold

needs cri-dockerd version 0.3.1

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2023
@spowelljr
Copy link
Member

@afbjorklund We're already on 0.3.1 #15752

@afbjorklund
Copy link
Collaborator

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16149) |
+----------------+----------+---------------------+
| minikube start | 50.2s    | 50.3s               |
| enable ingress | 27.0s    | 25.0s               |
+----------------+----------+---------------------+

Times for minikube start: 51.9s 48.0s 52.9s 46.4s 51.7s
Times for minikube (PR 16149) start: 51.4s 49.4s 47.4s 52.4s 50.9s

Times for minikube ingress: 28.2s 29.1s 24.1s 28.7s 24.7s
Times for minikube (PR 16149) ingress: 24.2s 24.6s 27.7s 24.1s 24.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16149) |
+----------------+----------+---------------------+
| minikube start | 23.4s    | 23.1s               |
| enable ingress | 27.8s    | 21.1s               |
+----------------+----------+---------------------+

Times for minikube (PR 16149) start: 23.3s 22.6s 23.5s 22.8s 23.2s
Times for minikube start: 23.9s 23.6s 24.0s 22.6s 23.1s

Times for minikube ingress: 21.5s 22.0s 22.6s 22.0s 50.6s
Times for minikube (PR 16149) ingress: 21.0s 20.1s 20.1s 22.6s 21.6s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16149) |
+----------------+----------+---------------------+
| minikube start | 21.6s    | 21.4s               |
| enable ingress | 41.8s    | 38.9s               |
+----------------+----------+---------------------+

Times for minikube start: 22.1s 22.1s 20.9s 22.2s 20.8s
Times for minikube (PR 16149) start: 21.5s 21.4s 21.8s 21.4s 21.1s

Times for minikube ingress: 81.0s 31.5s 31.5s 32.0s 33.0s
Times for minikube (PR 16149) ingress: 32.0s 31.5s 80.1s 19.5s 31.5s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyper-V_Windows TestMultiNode/serial/ValidateNameConflict (gopogh) 0.00 (chart)
KVM_Linux_containerd TestKVMDriverInstallOrUpdate (gopogh) 0.00 (chart)
KVM_Linux TestPause/serial/Start (gopogh) 0.00 (chart)
Hyper-V_Windows TestMinikubeProfile (gopogh) 3.17 (chart)
Hyper-V_Windows TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 98.41 (chart)
Hyper-V_Windows TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 98.41 (chart)
Hyper-V_Windows TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 98.41 (chart)
Hyper-V_Windows TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh) 98.41 (chart)
Hyper-V_Windows TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 98.41 (chart)
Hyper-V_Windows TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 98.41 (chart)
Hyper-V_Windows TestFunctional/parallel/ImageCommands/Setup (gopogh) 98.41 (chart)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) 100.00 (chart)
KVM_Linux_containerd TestPreload (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@spowelljr
Copy link
Member

I see cri-dockerd logs in failed tests

Mar 24 21:00:07 multinode-627400 cri-dockerd[1249]: time="2023-03-24T21:00:07Z" level=info msg="Will attempt to re-write config file /var/lib/docker/containers/5de56b494473be0c60ea426e0b2bcf9e8018fd8806429d0c87e729888a4f9f48/resolv.conf as [nameserver 172.30.176.1]"

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, maxbrunet, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit 764c5c3 into kubernetes:master Mar 27, 2023
@maxbrunet maxbrunet deleted the fix/cri-docker-system-logs branch March 27, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants