Fixed issue where mount threw an error on large folders

[aaron-prindle]

fixes #1562

[codecov-io]

Codecov Report

Merging #1604 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1604   +/-   ##
======================================
  Coverage    38.7%   38.7%           
======================================
  Files          51      51           
  Lines        2604    2604           
======================================
  Hits         1008    1008           
  Misses       1418    1418           
  Partials      178     178

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 968f24e...a8486f0. Read the comment docs.

[r2d4]

Can you add an integration test case with a really long filename? Would that be sufficient to test this?

[aaron-prindle]

linux has a maximum file-name length of 255 chars it seems https://serverfault.com/questions/9546/filename-length-limits-on-linux
The value that was causing issues was ~8300 or so. But we could have the test generate a dir full of files with long names (similar to the repo that was used in testing from the #1562)

[cu12]

@aaron-prindle Confirming that this works fine in my environment. (tho' I have another issue that the amount of reads(?) - it's a php app - leads to kernel panic, but I'm still investigating the possible root cause)

[aaron-prindle]

@cu12 Definitely post an issue regarding the amount of reads problem you are encountering if it appears that mount is the issue there.

[georgecrawford]

If this is a potential cause for the missing files issue I'm seeing (#1515), then it's a problem with a directory of only 127 files. They do have long-ish filenames (~70-80 chars).

[aaron-prindle]

Closing as setting the --msize flag is the appropriate way to this which was added in: #1705

[georgecrawford]

@aaron-prindle - do you think this would have been the cause of, and fix for #1515 ?

[aaron-prindle]

@georgecrawford yes, the issue was that if a directory listing exceeded the default msize, the 9p server would return an error (minikube mount) and the xhyve 9p server would return an incomplete listing. If you use minikube's 9p server (minikube mount --msize=) and configure this value, you should be able to use arbitrarily sized directories.