Fixed mtime issue for OSX #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
dlorenc
reviewed
Jun 15, 2017
third_party/go9p/srv_file.go
Outdated
| @@ -132,7 +133,11 @@ func (f *srvFile) Add(dir *srvFile, name string, uid User, gid Group, mode uint3 | |||
| f.Qid.Version = 0 | |||
| f.Qid.Path = qpath | |||
| f.Mode = mode | |||
| f.Atime = uint32(time.Now().Unix()) | |||
| if runtime.GOOS == "darwin" { | |||
There was a problem hiding this comment.
Could you leave a comment explaining this?
Codecov Report
@@ Coverage Diff @@
## master #1594 +/- ##
=========================================
- Coverage 38.78% 38.7% -0.08%
=========================================
Files 51 51
Lines 2604 2604
=========================================
- Hits 1010 1008 -2
- Misses 1417 1418 +1
- Partials 177 178 +1
Continue to review full report at Codecov.
|
dlorenc
approved these changes
Jun 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1375