Switch the API implementation to use the local APIs everywhere we can.

[dlorenc]

No description provided.

[r2d4]

The change LGTM, but looks like you need to also change the associated tests.

[codecov-io]

Codecov Report

Merging #1544 into master will decrease coverage by 0.15%.
The diff coverage is 26.66%.

@@            Coverage Diff             @@
##           master    #1544      +/-   ##
==========================================
- Coverage   39.52%   39.36%   -0.16%     
==========================================
  Files          50       50              
  Lines        2548     2548              
==========================================
- Hits         1007     1003       -4     
- Misses       1375     1378       +3     
- Partials      166      167       +1

Impacted Files	Coverage Δ
pkg/minikube/machine/client_linux.go	28.57% <ø> (+7.51%)	⬆️
cmd/minikube/cmd/root.go	67.79% <ø> (-0.54%)	⬇️
cmd/minikube/cmd/mount.go	5% <0%> (ø)	⬆️
cmd/minikube/cmd/logs.go	21.42% <0%> (ø)	⬆️
cmd/minikube/cmd/service_list.go	11.53% <0%> (ø)	⬆️
cmd/minikube/cmd/ip.go	11.76% <0%> (ø)	⬆️
cmd/minikube/cmd/start.go	17.05% <0%> (ø)	⬆️
cmd/minikube/cmd/stop.go	13.33% <0%> (ø)	⬆️
cmd/minikube/cmd/ssh.go	10.52% <0%> (ø)	⬆️
cmd/minikube/cmd/env.go	64.39% <0%> (ø)	⬆️
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae51e5f...96fdc2c. Read the comment docs.

[dlorenc]

@r2d4 ready for another look.

[dlorenc]

@minikube-bot test this pleas

[dlorenc]

@minikube-bot test this please

[r2d4]

LGTM

[dlorenc]

@minikube-bot test this please

[dlorenc]

@minikube-bot test this please

[aaron-prindle]

Was this passing the none driver test? It seems that no entry in ~/.minikube/machines being made now when using the none driver, trying to identify if this is related.

[dlorenc]

Was this passing the none driver test? It seems that no entry in ~/.minikube/machines being made now when using the none driver, trying to identify if this is related.

I think it did, but I guess we lose access to the history now that it's merged :(

[r2d4]

You can click on the "details" button on the merge history message in the PR and see the test history. Looks like the None driver was passing

https://storage.googleapis.com/minikube-builds/logs/1544/Linux-None.txt