Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented minimum and recommended Docker versions #13842

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Implemented minimum and recommended Docker versions #13842

merged 1 commit into from
Mar 24, 2022

Conversation

spowelljr
Copy link
Member

Fixes #11543

If user is using a Docker version older than the minimum supported version (18.09) will exit and notify them to update to a newer version, unless --force is specified.

If used is using a Docker version older than the recommended version (20.10) will notify them to update to a newer version, unless --force is specified.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 23, 2022
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13842) |
+----------------+----------+---------------------+
| minikube start | 51.3s    | 53.0s               |
| enable ingress | 27.7s    | 27.3s               |
+----------------+----------+---------------------+

Times for minikube (PR 13842) start: 52.2s 52.7s 52.1s 56.3s 51.6s
Times for minikube start: 53.2s 52.5s 51.6s 46.6s 52.5s

Times for minikube (PR 13842) ingress: 25.0s 29.5s 26.5s 26.5s 29.0s
Times for minikube ingress: 29.0s 25.6s 29.0s 29.0s 26.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13842) |
+----------------+----------+---------------------+
| minikube start | 25.7s    | 25.9s               |
| enable ingress | 28.2s    | 22.7s               |
+----------------+----------+---------------------+

Times for minikube start: 26.4s 25.3s 25.7s 26.0s 25.0s
Times for minikube (PR 13842) start: 26.2s 26.1s 25.6s 25.0s 26.5s

Times for minikube ingress: 20.9s 22.9s 21.9s 51.4s 23.9s
Times for minikube (PR 13842) ingress: 21.4s 22.4s 23.9s 21.9s 23.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13842) |
+----------------+----------+---------------------+
| minikube start | 41.3s    | 44.4s               |
| enable ingress | 23.5s    | 22.4s               |
+----------------+----------+---------------------+

Times for minikube (PR 13842) start: 45.5s 44.8s 46.2s 44.8s 40.9s
Times for minikube start: 33.8s 45.7s 41.0s 45.0s 41.0s

Times for minikube ingress: 18.9s 16.9s 32.4s 16.9s 32.5s
Times for minikube (PR 13842) ingress: 16.9s 17.9s 26.9s 18.9s 31.5s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_containerd TestAddons/Setup (gopogh) 0.61 (chart)
KVM_Linux_containerd TestCertExpiration (gopogh) 0.61 (chart)
KVM_Linux_containerd TestCertOptions (gopogh) 0.61 (chart)
KVM_Linux_containerd TestErrorSpam/setup (gopogh) 0.61 (chart)
KVM_Linux_containerd TestForceSystemdEnv (gopogh) 0.61 (chart)
KVM_Linux_containerd TestForceSystemdFlag (gopogh) 0.61 (chart)
KVM_Linux_containerd TestFunctional/parallel/CertSync (gopogh) 0.61 (chart)
KVM_Linux_containerd TestFunctional/parallel/CpCmd (gopogh) 0.61 (chart)
KVM_Linux_containerd TestFunctional/parallel/FileSync (gopogh) 0.61 (chart)
KVM_Linux_containerd TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 0.61 (chart)
KVM_Linux_containerd TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 0.61 (chart)
KVM_Linux_containerd TestFunctional/parallel/ImageCommands/ImageListShort (gopogh) 0.61 (chart)
KVM_Linux_containerd TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 0.61 (chart)
KVM_Linux_containerd TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 0.61 (chart)
KVM_Linux_containerd TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 0.61 (chart)
KVM_Linux_containerd TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 0.61 (chart)
KVM_Linux_containerd TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 0.61 (chart)
KVM_Linux_containerd TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 0.61 (chart)
KVM_Linux_containerd TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 0.61 (chart)
KVM_Linux_containerd TestFunctional/parallel/MountCmd/any-port (gopogh) 0.61 (chart)
KVM_Linux_containerd TestFunctional/parallel/MySQL (gopogh) 0.61 (chart)
KVM_Linux_containerd TestFunctional/parallel/NodeLabels (gopogh) 0.61 (chart)
KVM_Linux_containerd TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 0.61 (chart)
KVM_Linux_containerd TestFunctional/parallel/PersistentVolumeClaim (gopogh) 0.61 (chart)
KVM_Linux_containerd TestFunctional/parallel/ServiceCmd (gopogh) 0.61 (chart)
KVM_Linux_containerd TestFunctional/parallel/ServiceCmdConnect (gopogh) 0.61 (chart)
KVM_Linux_containerd TestFunctional/parallel/SSHCmd (gopogh) 0.61 (chart)
KVM_Linux_containerd TestFunctional/parallel/StatusCmd (gopogh) 0.61 (chart)
KVM_Linux_containerd TestFunctional/parallel/UpdateContextCmd/no_changes (gopogh) 0.61 (chart)
KVM_Linux_containerd TestFunctional/parallel/UpdateContextCmd/no_clusters (gopogh) 0.61 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr
Copy link
Member Author

KVM Linux machine is experiencing issues, running tests again

@spowelljr
Copy link
Member Author

/retest-this-please

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13842) |
+----------------+----------+---------------------+
| minikube start | 53.0s    | 52.6s               |
| enable ingress | 30.1s    | 27.9s               |
+----------------+----------+---------------------+

Times for minikube ingress: 30.6s 30.6s 29.6s 29.6s 30.1s
Times for minikube (PR 13842) ingress: 30.1s 28.6s 25.1s 30.1s 25.6s

Times for minikube start: 53.7s 52.0s 53.4s 52.2s 53.6s
Times for minikube (PR 13842) start: 52.7s 52.7s 52.2s 52.5s 52.7s

docker driver with docker runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10
docker driver with containerd runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux TestPause/serial/Pause (gopogh) 8.93 (chart)
KVM_Linux_containerd TestPause/serial/SecondStartNoReconfiguration (gopogh) 11.56 (chart)
Docker_Windows TestForceSystemdEnv (gopogh) 12.70 (chart)
Hyper-V_Windows TestSkaffold (gopogh) 13.70 (chart)
Docker_macOS TestFunctional/parallel/DashboardCmd (gopogh) 14.29 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/custom-weave/Start (gopogh) 14.75 (chart)
Docker_Windows TestSkaffold (gopogh) 15.87 (chart)
Docker_Windows TestNetworkPlugins/group/false/Start (gopogh) 16.25 (chart)
Docker_Windows TestPause/serial/Pause (gopogh) 19.30 (chart)
Docker_Windows TestNoKubernetes/serial/StartWithStopK8s (gopogh) 30.89 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 30.95 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 45.36 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/Start (gopogh) 46.43 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 48.15 (chart)
Docker_Windows TestNetworkPlugins/group/custom-weave/Start (gopogh) 50.62 (chart)
Docker_macOS TestNetworkPlugins/group/calico/Start (gopogh) 57.14 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/kindnet/DNS (gopogh) 58.33 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 59.29 (chart)
Docker_Linux TestNetworkPlugins/group/custom-weave/Start (gopogh) 61.90 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/DNS (gopogh) 62.50 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 65.52 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 70.55 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 76.19 (chart)
Docker_Windows TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh) 76.19 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 78.74 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 80.33 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 85.27 (chart)
Docker_macOS TestDownloadOnly/v1.16.0/preload-exists (gopogh) 100.00 (chart)
Docker_Windows TestFunctional/parallel/ServiceCmd (gopogh) 100.00 (chart)
Docker_Windows TestNetworkPlugins/group/cilium/Start (gopogh) 100.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit 016ef2e into kubernetes:master Mar 24, 2022
@spowelljr spowelljr deleted the requireDockerVersion branch March 24, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klaases klaases klaases approved these changes

@blueelvis blueelvis Awaiting requested review from blueelvis

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exit with error when Docker version is too old
4 participants
@spowelljr @k8s-ci-robot @minikube-pr-bot @klaases