Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO: Upgrade falco-module to version 0.28.0 #13331

Closed
wants to merge 2 commits into from
Closed

ISO: Upgrade falco-module to version 0.28.0 #13331

wants to merge 2 commits into from

Conversation

afbjorklund
Copy link
Collaborator

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2022
@afbjorklund afbjorklund changed the title Upgrade falco-module to version 0.28.0 ISO: Upgrade falco-module to version 0.28.0 Jan 12, 2022
@medyagh

This comment was marked as outdated.

Sign in to view
@klaases
Copy link
Contributor

klaases commented Jan 12, 2022

Looking forward - this may resolve the build errors seen recently with sysdig 0.23 when building an ARM64 ISO.

#13178

@minikube-bot

This comment was marked as outdated.

Sign in to view
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 12, 2022
@medyagh
Copy link
Member

medyagh commented Jan 12, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 12, 2022
@minikube-pr-bot

This comment was marked as outdated.

Sign in to view
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 19, 2022
@afbjorklund
Copy link
Collaborator Author

@klaases should we do something more with this ? maybe upgrade to 0.31.0 as well ?

https://github.com/falcosecurity/falco/releases

@afbjorklund afbjorklund mentioned this pull request Feb 22, 2022
Merged
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13331) |
+----------------+----------+---------------------+
| minikube start | 52.9s    | 53.2s               |
| enable ingress | 28.3s    | 28.0s               |
+----------------+----------+---------------------+

Times for minikube start: 52.8s 52.4s 55.6s 51.8s 51.9s
Times for minikube (PR 13331) start: 54.7s 51.9s 52.0s 52.2s 55.1s

Times for minikube ingress: 29.6s 29.6s 26.0s 26.6s 29.6s
Times for minikube (PR 13331) ingress: 30.6s 25.1s 28.5s 29.0s 27.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13331) |
+----------------+----------+---------------------+
| minikube start | 27.3s    | 25.9s               |
| enable ingress | 22.2s    | 22.6s               |
+----------------+----------+---------------------+

Times for minikube start: 31.1s 26.4s 26.7s 26.1s 26.5s
Times for minikube (PR 13331) start: 25.9s 25.4s 26.9s 25.5s 25.8s

Times for minikube ingress: 21.9s 22.4s 22.9s 21.9s 21.9s
Times for minikube (PR 13331) ingress: 21.9s 22.9s 22.4s 23.0s 22.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13331) |
+----------------+----------+---------------------+
| minikube start | 41.1s    | 43.1s               |
| enable ingress | 23.4s    | 24.0s               |
+----------------+----------+---------------------+

Times for minikube start: 34.6s 46.2s 40.5s 42.0s 42.2s
Times for minikube (PR 13331) start: 41.5s 41.6s 41.4s 44.9s 46.0s

Times for minikube ingress: 18.9s 18.9s 23.4s 32.9s 22.9s
Times for minikube (PR 13331) ingress: 23.4s 23.4s 24.4s 19.9s 28.9s

@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 2, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13331) |
+----------------+----------+---------------------+
| minikube start | 53.5s    | 53.5s               |
| enable ingress | 29.9s    | 30.1s               |
+----------------+----------+---------------------+

Times for minikube ingress: 29.6s 29.1s 30.1s 31.1s 29.7s
Times for minikube (PR 13331) ingress: 31.2s 30.1s 29.1s 29.6s 30.6s

Times for minikube start: 54.1s 53.2s 54.2s 52.6s 53.3s
Times for minikube (PR 13331) start: 53.0s 53.5s 53.5s 54.0s 53.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13331) |
+----------------+----------+---------------------+
| minikube start | 28.3s    | 27.3s               |
| enable ingress | 23.0s    | 22.8s               |
+----------------+----------+---------------------+

Times for minikube start: 32.1s 27.1s 28.0s 27.3s 27.0s
Times for minikube (PR 13331) start: 27.0s 27.9s 27.0s 27.1s 27.6s

Times for minikube ingress: 23.0s 23.0s 22.4s 22.0s 24.5s
Times for minikube (PR 13331) ingress: 23.4s 22.5s 22.0s 23.0s 23.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13331) |
+----------------+----------+---------------------+
| minikube start | 40.9s    | 44.7s               |
| enable ingress | 28.5s    | 26.9s               |
+----------------+----------+---------------------+

Times for minikube start: 31.9s 42.0s 46.6s 42.1s 42.1s
Times for minikube (PR 13331) start: 47.0s 45.9s 41.2s 42.7s 46.8s

Times for minikube (PR 13331) ingress: 19.0s 29.0s 33.5s 34.0s 19.0s
Times for minikube ingress: 54.0s 23.0s 19.0s 23.5s 22.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestNetworkPlugins/group/custom-weave/KubeletFlags (gopogh) 0.00 (chart)
Hyper-V_Windows TestNetworkPlugins/group/calico/NetCatPod (gopogh) 0.00 (chart)
KVM_Linux TestFunctional/parallel/MountCmd/specific-port (gopogh) 0.00 (chart)
KVM_Linux_containerd TestFunctional/parallel/DashboardCmd (gopogh) 3.77 (chart)
Docker_Linux_containerd TestNoKubernetes/serial/Start (gopogh) 3.97 (chart)
Hyperkit_macOS TestFunctional/serial/ComponentHealth (gopogh) 4.61 (chart)
Hyper-V_Windows TestNetworkPlugins/group/custom-weave/Start (gopogh) 8.21 (chart)
Hyper-V_Windows TestNetworkPlugins/group/false/Start (gopogh) 11.19 (chart)
Docker_Windows TestNetworkPlugins/group/auto/DNS (gopogh) 18.37 (chart)
Docker_Windows TestNetworkPlugins/group/false/DNS (gopogh) 19.10 (chart)
Docker_Windows TestPause/serial/Pause (gopogh) 20.62 (chart)
Hyper-V_Windows TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 20.90 (chart)
Hyper-V_Windows TestNetworkPlugins/group/flannel/Start (gopogh) 24.63 (chart)
Hyper-V_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 31.34 (chart)
Docker_Windows TestNoKubernetes/serial/StartWithStopK8s (gopogh) 34.29 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 38.32 (chart)
Hyper-V_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 39.55 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 40.35 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 40.35 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 40.35 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 40.87 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 43.86 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 43.86 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 44.35 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 44.83 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/Start (gopogh) 45.59 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 46.73 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 49.53 (chart)
Docker_Linux TestNetworkPlugins/group/kindnet/Start (gopogh) 51.35 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/kindnet/Start (gopogh) 51.69 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestDownloadOnlyKic (gopogh) 7.80 (chart)
Docker_macOS TestDownloadOnly/v1.23.3/preload-exists (gopogh) 7.80 (chart)
Docker_Linux TestPause/serial/Pause (gopogh) 8.78 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/NetCatPod (gopogh) 9.26 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/auto/DNS (gopogh) 14.41 (chart)
Docker_Linux_containerd TestAddons/Setup (gopogh) 20.13 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 20.13 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 20.13 (chart)
Docker_Linux_containerd TestJSONOutput/start/Audit (gopogh) 20.13 (chart)
Docker_Linux_containerd TestJSONOutput/start/Command (gopogh) 20.13 (chart)
Docker_Linux_containerd TestMultiNode/serial/AddNode (gopogh) 20.13 (chart)
Docker_Linux_containerd TestMultiNode/serial/DeleteNode (gopogh) 20.13 (chart)
Docker_Linux_containerd TestMultiNode/serial/FreshStart2Nodes (gopogh) 20.13 (chart)
Docker_Linux_containerd TestMultiNode/serial/ProfileList (gopogh) 20.13 (chart)
Docker_Linux_containerd TestMultiNode/serial/RestartKeepsNodes (gopogh) 20.13 (chart)
Docker_Linux_containerd TestMultiNode/serial/RestartMultiNode (gopogh) 20.13 (chart)
Docker_Linux_containerd TestMultiNode/serial/StartAfterStop (gopogh) 20.13 (chart)
Docker_Linux_containerd TestMultiNode/serial/StopNode (gopogh) 20.13 (chart)
Docker_Linux_containerd TestPreload (gopogh) 20.13 (chart)
Docker_Windows TestPause/serial/Pause (gopogh) 20.62 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 21.70 (chart)
Docker_Linux_containerd TestOffline (gopogh) 22.08 (chart)
Docker_Windows TestKubernetesUpgrade (gopogh) 22.43 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 22.58 (chart)
Docker_Linux_containerd TestPause/serial/Start (gopogh) 22.73 (chart)
Docker_Linux_containerd TestFunctional/parallel/DashboardCmd (gopogh) 30.52 (chart)
Docker_Linux_containerd TestFunctional/parallel/MountCmd/any-port (gopogh) 30.52 (chart)
Docker_Linux_containerd TestFunctional/parallel/MySQL (gopogh) 30.52 (chart)
Docker_Linux_containerd TestFunctional/parallel/PersistentVolumeClaim (gopogh) 30.52 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmd (gopogh) 30.52 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2022
@k8s-ci-robot
Copy link
Contributor

@afbjorklund: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh left review comments

@klaases klaases Awaiting requested review from klaases

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@afbjorklund @k8s-ci-robot @medyagh @klaases @minikube-bot @minikube-pr-bot