Support rootless Podman driver ( `minikube start --driver=podman --rootless --container-runtime=(cri-o|containerd)`) #12901

AkihiroSuda · 2021-11-09T08:30:19Z

Usage: minikube start --driver=podman --rootless --container-runtime=(cri-o|containerd)
Tested on Podman 3.4.1, Ubuntu 21.10.

Needs cgroup v2 (as in Rootless Docker): https://rootlesscontaine.rs/getting-started/common/cgroup2/
See also site/content/en/docs/drivers/includes/podman_usage.inc

Fix #8719
Fix #12460
Follow-up to #12359 (Rootless Docker driver)

minikube-bot · 2021-11-09T08:32:04Z

Can one of the admins verify this patch?

medyagh

thank you for this PR, I think we just need to delete where we set the env and let "viper" lib take care of setting the env

medyagh · 2021-11-12T00:24:39Z

cmd/minikube/cmd/start.go

@@ -135,6 +135,10 @@ func platform() string {

 // runStart handles the executes the flow of "minikube start"
 func runStart(cmd *cobra.Command, args []string) {
+	if cmd.Flag(rootless).Changed {
+		// env is internally used by kic runner
+		os.Setenv(constants.MinikubeRootlessEnv, strconv.FormatBool(viper.GetBool(rootless)))


don't think we need to set env I believe viper lib already sets the env from the flags
check the other usages of Env as flag

MinikubeForceSystemdEnv = "MINIKUBE_FORCE_SYSTEMD"

so I believe we could delete this code

viper seems to map $MINIKUBE_ROOTLESS to --rootless automatically, but it does not do vice versa.

Updated the comment lines to clarify that.

makes sense, thank you for the clarification

AkihiroSuda · 2021-11-19T09:57:14Z

@afbjorklund Could you take a look

medyagh

thank you for this PR

medyagh · 2021-12-07T22:52:18Z

/ok-to-test

minikube-pr-bot · 2021-12-08T01:00:07Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12901) |
+----------------+----------+---------------------+
| minikube start | 45.8s    | 45.0s               |
| enable ingress | 29.3s    | 29.4s               |
+----------------+----------+---------------------+

Times for minikube start: 49.7s 44.1s 44.6s 46.1s 44.4s
Times for minikube (PR 12901) start: 44.7s 44.6s 45.9s 44.6s 45.4s

Times for minikube ingress: 29.0s 30.1s 29.0s 29.1s 29.1s
Times for minikube (PR 12901) ingress: 30.1s 28.6s 29.6s 29.6s 29.1s

docker driver with docker runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10
docker driver with containerd runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10

minikube-pr-bot · 2021-12-08T03:09:19Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
KVM_Linux_containerd	TestNetworkPlugins/group/bridge/Start (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestNetworkPlugins/group/custom-weave/Start (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestNoKubernetes/serial/StartWithStopK8s (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestStartStop/group/default-k8s-different-port/serial/EnableAddonWhileActive (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestStartStop/group/no-preload/serial/DeployApp (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestStartStop/group/no-preload/serial/EnableAddonWhileActive (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestStartStop/group/no-preload/serial/FirstStart (gopogh)	0.00 (chart)
KVM_Linux	TestPause/serial/SecondStartNoReconfiguration (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestNetworkPlugins/group/kindnet/Start (gopogh)	1.06 (chart)
KVM_Linux_containerd	TestStoppedBinaryUpgrade/MinikubeLogs (gopogh)	1.06 (chart)
KVM_Linux	TestCertExpiration (gopogh)	1.61 (chart)
KVM_Linux_containerd	TestStoppedBinaryUpgrade/Upgrade (gopogh)	3.19 (chart)
Docker_Linux_containerd	TestStartStop/group/newest-cni/serial/Pause (gopogh)	3.27 (chart)
KVM_Linux_containerd	TestPause/serial/SecondStartNoReconfiguration (gopogh)	4.26 (chart)
Docker_macOS	TestNetworkPlugins/group/false/DNS (gopogh)	4.30 (chart)
KVM_Linux	TestNoKubernetes/serial/StartWithK8s (gopogh)	9.09 (chart)
Docker_macOS	TestNetworkPlugins/group/calico/DNS (gopogh)	17.24 (chart)
Docker_macOS	TestNetworkPlugins/group/kindnet/DNS (gopogh)	28.12 (chart)
Docker_macOS	TestNetworkPlugins/group/bridge/Start (gopogh)	29.06 (chart)
Docker_macOS	TestFunctional/serial/ComponentHealth (gopogh)	37.41 (chart)
Docker_macOS	TestFunctional/serial/ExtraConfig (gopogh)	37.41 (chart)
Docker_macOS	TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh)	39.02 (chart)
Docker_macOS	TestNetworkPlugins/group/kubenet/Start (gopogh)	42.24 (chart)
Docker_macOS	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	75.00 (chart)
Docker_macOS	TestDownloadOnly/v1.16.0/preload-exists (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

sharifelgamal · 2021-12-13T23:27:44Z

/ok-to-test

minikube-pr-bot · 2021-12-14T01:00:51Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12901) |
+----------------+----------+---------------------+
| minikube start | 46.5s    | 44.8s               |
| enable ingress | 30.2s    | 29.9s               |
+----------------+----------+---------------------+

Times for minikube start: 51.8s 45.0s 44.9s 44.8s 45.9s
Times for minikube (PR 12901) start: 44.4s 44.9s 44.9s 44.6s 45.1s

Times for minikube ingress: 29.6s 29.6s 29.6s 30.6s 31.6s
Times for minikube (PR 12901) ingress: 29.6s 30.1s 29.6s 30.1s 30.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12901) |
+----------------+----------+---------------------+
| minikube start | 26.8s    | 27.0s               |
| enable ingress | 23.0s    | 23.5s               |
+----------------+----------+---------------------+

Times for minikube start: 27.4s 26.9s 26.8s 26.2s 26.8s
Times for minikube (PR 12901) start: 27.7s 27.4s 26.2s 26.8s 26.7s

Times for minikube ingress: 22.9s 22.9s 23.4s 22.9s 22.9s
Times for minikube (PR 12901) ingress: 25.4s 23.0s 22.9s 23.4s 22.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12901) |
+----------------+----------+---------------------+
| minikube start | 42.4s    | 44.3s               |
| enable ingress | 42.0s    | 32.7s               |
+----------------+----------+---------------------+

Times for minikube start: 44.4s 41.9s 41.6s 41.7s 42.4s
Times for minikube (PR 12901) start: 45.4s 42.1s 45.8s 46.3s 42.0s

Times for minikube ingress: 64.9s 37.4s 36.9s 33.4s 37.4s
Times for minikube (PR 12901) ingress: 30.4s 37.9s 28.9s 28.9s 37.4s

minikube-pr-bot · 2021-12-14T03:15:48Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Hyper-V_Windows	TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh)	0.00 (chart)
Hyper-V_Windows	TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh)	0.00 (chart)
Hyper-V_Windows	TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh)	0.00 (chart)
KVM_Linux	TestMountStart/serial/RestartStopped (gopogh)	0.00 (chart)
KVM_Linux	TestMountStart/serial/StartWithMountSecond (gopogh)	0.00 (chart)
KVM_Linux	TestMountStart/serial/Stop (gopogh)	0.00 (chart)
KVM_Linux	TestMountStart/serial/VerifyMountPostDelete (gopogh)	0.00 (chart)
KVM_Linux	TestMountStart/serial/VerifyMountPostStop (gopogh)	0.00 (chart)
KVM_Linux	TestMountStart/serial/VerifyMountSecond (gopogh)	0.00 (chart)
KVM_Linux	TestMultiNode/serial/AddNode (gopogh)	0.00 (chart)
KVM_Linux	TestMultiNode/serial/CopyFile (gopogh)	0.00 (chart)
KVM_Linux	TestMultiNode/serial/DeleteNode (gopogh)	0.00 (chart)
KVM_Linux	TestMultiNode/serial/DeployApp2Nodes (gopogh)	0.00 (chart)
KVM_Linux	TestMultiNode/serial/FreshStart2Nodes (gopogh)	0.00 (chart)
KVM_Linux	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	0.00 (chart)
KVM_Linux	TestMultiNode/serial/ProfileList (gopogh)	0.00 (chart)
KVM_Linux	TestMultiNode/serial/RestartKeepsNodes (gopogh)	0.00 (chart)
KVM_Linux	TestMultiNode/serial/RestartMultiNode (gopogh)	0.00 (chart)
KVM_Linux	TestMultiNode/serial/StartAfterStop (gopogh)	0.00 (chart)
KVM_Linux	TestMultiNode/serial/StopMultiNode (gopogh)	0.00 (chart)
KVM_Linux	TestMultiNode/serial/StopNode (gopogh)	0.00 (chart)
KVM_Linux	TestNetworkPlugins/group/auto/Start (gopogh)	0.00 (chart)
KVM_Linux	TestNoKubernetes/serial/Stop (gopogh)	0.00 (chart)
KVM_Linux	TestPause/serial/Pause (gopogh)	0.00 (chart)
KVM_Linux	TestPause/serial/PauseAgain (gopogh)	0.00 (chart)
KVM_Linux	TestPause/serial/Unpause (gopogh)	0.00 (chart)
KVM_Linux	TestPause/serial/VerifyStatus (gopogh)	0.00 (chart)
KVM_Linux	TestPreload (gopogh)	0.00 (chart)
KVM_Linux	TestScheduledStopUnix (gopogh)	0.00 (chart)
KVM_Linux	TestSkaffold (gopogh)	0.00 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

AkihiroSuda · 2021-12-23T02:46:11Z

Is there any remaining task that I have to do?
CI flakes are probably unrelated.

AkihiroSuda · 2022-01-13T04:35:12Z

Rebased

AkihiroSuda · 2022-02-03T06:10:47Z

rebased

minikube-pr-bot · 2022-02-03T06:57:46Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12901) |
+----------------+----------+---------------------+
| minikube start | 51.3s    | 49.7s               |
| enable ingress | 29.0s    | 28.6s               |
+----------------+----------+---------------------+

Times for minikube start: 49.8s 50.9s 52.0s 52.6s 51.2s
Times for minikube (PR 12901) start: 50.7s 51.4s 52.3s 46.6s 47.6s

Times for minikube ingress: 28.5s 29.5s 29.0s 29.0s 29.1s
Times for minikube (PR 12901) ingress: 25.5s 30.0s 29.6s 29.5s 28.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12901) |
+----------------+----------+---------------------+
| minikube start | 25.8s    | 25.8s               |
| enable ingress | 22.3s    | 22.5s               |
+----------------+----------+---------------------+

Times for minikube ingress: 22.9s 22.9s 22.9s 21.9s 20.9s
Times for minikube (PR 12901) ingress: 22.4s 23.5s 22.4s 22.5s 21.9s

Times for minikube start: 26.9s 25.7s 25.0s 25.6s 25.6s
Times for minikube (PR 12901) start: 26.5s 25.4s 25.6s 25.9s 25.7s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12901) |
+----------------+----------+---------------------+
| minikube start | 41.6s    | 42.0s               |
| enable ingress | 20.7s    | 22.6s               |
+----------------+----------+---------------------+

Times for minikube start: 31.0s 45.5s 44.5s 45.2s 41.7s
Times for minikube (PR 12901) start: 41.5s 40.9s 41.1s 40.8s 45.8s

Times for minikube ingress: 23.4s 19.4s 18.9s 18.9s 22.9s
Times for minikube (PR 12901) ingress: 22.9s 23.4s 22.9s 23.4s 20.4s

minikube-pr-bot · 2022-02-03T09:19:29Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd	TestStartStop/group/newest-cni/serial/SecondStart (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestStartStop/group/newest-cni/serial/VerifyKubernetesImages (gopogh)	0.00 (chart)
Docker_Windows	TestMultiNode/serial/ValidateNameConflict (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestStartStop/group/newest-cni/serial/Pause (gopogh)	2.27 (chart)
Docker_Windows	TestStartStop/group/newest-cni/serial/EnableAddonAfterStop (gopogh)	3.03 (chart)
Docker_Windows	TestStartStop/group/newest-cni/serial/Stop (gopogh)	3.03 (chart)
Docker_Linux_containerd	TestNoKubernetes/serial/ProfileList (gopogh)	3.45 (chart)
Docker_Windows	TestStartStop/group/newest-cni/serial/FirstStart (gopogh)	4.55 (chart)
KVM_Linux	TestForceSystemdEnv (gopogh)	4.90 (chart)
Hyperkit_macOS	TestFunctional/parallel/DashboardCmd (gopogh)	13.89 (chart)
Docker_macOS	TestAddons/parallel/MetricsServer (gopogh)	23.47 (chart)
Docker_macOS	TestStartStop/group/newest-cni/serial/SecondStart (gopogh)	24.39 (chart)
Docker_Windows	TestRunningBinaryUpgrade (gopogh)	24.64 (chart)
Docker_Windows	TestPause/serial/Pause (gopogh)	28.33 (chart)
Docker_Windows	TestStartStop/group/newest-cni/serial/Pause (gopogh)	43.94 (chart)
Docker_Windows	TestNetworkPlugins/group/kindnet/Start (gopogh)	47.83 (chart)
Hyper-V_Windows	TestNoKubernetes/serial/StartWithK8s (gopogh)	60.00 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh)	70.45 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh)	71.11 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh)	71.74 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh)	72.34 (chart)
Docker_Windows	TestNoKubernetes/serial/StartWithStopK8s (gopogh)	74.63 (chart)
Docker_Windows	TestAddons/parallel/MetricsServer (gopogh)	88.41 (chart)
Docker_macOS	TestDownloadOnly/v1.16.0/preload-exists (gopogh)	100.00 (chart)
Docker_Windows	TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh)	100.00 (chart)
Docker_Windows	TestNetworkPlugins/group/cilium/Start (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/RestartKeepsNodes (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

AkihiroSuda · 2022-02-07T07:54:22Z

@medyagh @afbjorklund Is there any remaining task to get this merged? 🙏
Thanks

minikube-pr-bot · 2022-02-16T05:49:46Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12901) |
+----------------+----------+---------------------+
| minikube start | 52.8s    | 52.0s               |
| enable ingress | 28.8s    | 27.8s               |
+----------------+----------+---------------------+

Times for minikube start: 53.5s 51.5s 52.4s 53.2s 53.4s
Times for minikube (PR 12901) start: 52.9s 51.4s 52.0s 52.2s 51.7s

Times for minikube (PR 12901) ingress: 25.1s 30.5s 28.5s 25.5s 29.6s
Times for minikube ingress: 29.5s 30.5s 29.0s 29.1s 25.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12901) |
+----------------+----------+---------------------+
| minikube start | 26.9s    | 26.0s               |
| enable ingress | 22.4s    | 22.6s               |
+----------------+----------+---------------------+

Times for minikube (PR 12901) start: 25.2s 25.8s 26.3s 27.2s 25.8s
Times for minikube start: 30.9s 25.7s 25.7s 25.8s 26.5s

Times for minikube ingress: 21.9s 21.9s 22.4s 23.0s 22.9s
Times for minikube (PR 12901) ingress: 20.9s 23.4s 22.9s 22.9s 22.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12901) |
+----------------+----------+---------------------+
| minikube start | 39.8s    | 43.6s               |
| enable ingress | 24.3s    | 20.9s               |
+----------------+----------+---------------------+

Times for minikube start: 30.4s 45.4s 40.6s 41.2s 41.5s
Times for minikube (PR 12901) start: 45.1s 40.3s 45.3s 45.6s 41.7s

Times for minikube ingress: 23.4s 18.9s 33.4s 22.9s 22.9s
Times for minikube (PR 12901) ingress: 18.9s 23.4s 19.4s 19.4s 23.4s

minikube-pr-bot · 2022-02-16T07:17:38Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
KVM_Linux_containerd	TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh)	0.78 (chart)
KVM_Linux_containerd	TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh)	0.78 (chart)
KVM_Linux_containerd	TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh)	0.78 (chart)
Docker_Linux	TestStartStop/group/old-k8s-version/serial/Pause (gopogh)	10.26 (chart)
Hyperkit_macOS	TestFunctional/parallel/DashboardCmd (gopogh)	14.63 (chart)
Docker_macOS	TestNetworkPlugins/group/cilium/Start (gopogh)	17.98 (chart)
Docker_Linux	TestFunctional/serial/ComponentHealth (gopogh)	20.51 (chart)
Docker_Linux_containerd	TestAddons/Setup (gopogh)	23.77 (chart)
Docker_Linux_containerd	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	23.77 (chart)
Docker_Linux_containerd	TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh)	23.77 (chart)
Docker_Linux_containerd	TestJSONOutput/start/Audit (gopogh)	23.77 (chart)
Docker_Linux_containerd	TestJSONOutput/start/Command (gopogh)	23.77 (chart)
Docker_Linux_containerd	TestMultiNode/serial/AddNode (gopogh)	23.77 (chart)
Docker_Linux_containerd	TestMultiNode/serial/DeleteNode (gopogh)	23.77 (chart)
Docker_Linux_containerd	TestMultiNode/serial/FreshStart2Nodes (gopogh)	23.77 (chart)
Docker_Linux_containerd	TestMultiNode/serial/ProfileList (gopogh)	23.77 (chart)
Docker_Linux_containerd	TestMultiNode/serial/RestartKeepsNodes (gopogh)	23.77 (chart)
Docker_Linux_containerd	TestMultiNode/serial/StartAfterStop (gopogh)	23.77 (chart)
Docker_Linux_containerd	TestMultiNode/serial/StopNode (gopogh)	23.77 (chart)
Docker_Linux_containerd	TestPreload (gopogh)	23.77 (chart)
Docker_Linux_containerd	TestMultiNode/serial/RestartMultiNode (gopogh)	24.59 (chart)
Docker_Linux_containerd	TestPause/serial/Start (gopogh)	27.05 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/DeployApp (gopogh)	30.34 (chart)
Docker_Linux_containerd	TestFunctional/parallel/DashboardCmd (gopogh)	31.15 (chart)
Docker_Linux_containerd	TestFunctional/parallel/MountCmd/any-port (gopogh)	31.15 (chart)
Docker_Linux_containerd	TestFunctional/parallel/MySQL (gopogh)	31.15 (chart)
Docker_Linux_containerd	TestFunctional/parallel/PersistentVolumeClaim (gopogh)	31.15 (chart)
Docker_Linux_containerd	TestFunctional/parallel/ServiceCmd (gopogh)	31.15 (chart)
Docker_Linux_containerd	TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh)	31.15 (chart)
Docker_Linux_containerd	TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh)	31.15 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

sharifelgamal · 2022-02-17T21:01:08Z

/ok-to-test

minikube-pr-bot · 2022-02-17T22:37:55Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12901) |
+----------------+----------+---------------------+
| minikube start | 53.3s    | 53.5s               |
| enable ingress | 28.8s    | 28.3s               |
+----------------+----------+---------------------+

Times for minikube start: 53.7s 52.7s 52.8s 53.8s 53.7s
Times for minikube (PR 12901) start: 53.8s 53.4s 52.9s 53.6s 54.1s

Times for minikube (PR 12901) ingress: 29.1s 26.1s 26.1s 29.6s 30.6s
Times for minikube ingress: 28.1s 30.1s 29.7s 26.6s 29.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12901) |
+----------------+----------+---------------------+
| minikube start | 27.6s    | 27.3s               |
| enable ingress | 22.8s    | 34.6s               |
+----------------+----------+---------------------+

Times for minikube start: 30.9s 26.8s 26.4s 27.0s 26.8s
Times for minikube (PR 12901) start: 26.8s 27.8s 27.7s 26.8s 27.4s

Times for minikube ingress: 21.9s 23.4s 23.9s 22.5s 22.5s
Times for minikube (PR 12901) ingress: 23.0s 21.4s 22.5s 23.0s 83.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12901) |
+----------------+----------+---------------------+
| minikube start | 42.3s    | 42.7s               |
| enable ingress | 25.5s    | 24.5s               |
+----------------+----------+---------------------+

Times for minikube start: 35.2s 45.8s 45.5s 42.0s 42.9s
Times for minikube (PR 12901) start: 40.7s 42.6s 46.0s 41.8s 42.1s

Times for minikube ingress: 30.0s 20.0s 20.0s 24.0s 33.4s
Times for minikube (PR 12901) ingress: 23.5s 33.0s 19.0s 23.9s 23.0s

minikube-pr-bot · 2022-02-17T23:51:35Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_macOS	TestSkaffold (gopogh)	0.00 (chart)
KVM_Linux	TestNoKubernetes/serial/ProfileList (gopogh)	0.00 (chart)
Docker_macOS	TestCertOptions (gopogh)	4.17 (chart)
Docker_macOS	TestDockerFlags (gopogh)	4.17 (chart)
Docker_macOS	TestForceSystemdEnv (gopogh)	4.17 (chart)
Docker_macOS	TestForceSystemdFlag (gopogh)	4.17 (chart)
Docker_macOS	TestRunningBinaryUpgrade (gopogh)	5.00 (chart)
Docker_macOS	TestCertExpiration (gopogh)	5.83 (chart)
Docker_macOS	TestKubernetesUpgrade (gopogh)	9.17 (chart)
Docker_Linux_containerd	TestStoppedBinaryUpgrade/MinikubeLogs (gopogh)	10.53 (chart)
Docker_Linux_containerd	TestStoppedBinaryUpgrade/Upgrade (gopogh)	10.53 (chart)
Docker_macOS	TestNoKubernetes/serial/StartWithK8s (gopogh)	12.50 (chart)
Docker_macOS	TestPause/serial/Start (gopogh)	12.50 (chart)
Docker_macOS	TestNoKubernetes/serial/ProfileList (gopogh)	13.04 (chart)
Docker_macOS	TestNoKubernetes/serial/StartNoArgs (gopogh)	13.04 (chart)
Docker_macOS	TestNoKubernetes/serial/Stop (gopogh)	13.04 (chart)
Docker_macOS	TestNoKubernetes/serial/StartWithStopK8s (gopogh)	14.17 (chart)
Docker_macOS	TestNoKubernetes/serial/Start (gopogh)	15.25 (chart)
Docker_macOS	TestNetworkPlugins/group/auto/Start (gopogh)	15.79 (chart)
Docker_macOS	TestNetworkPlugins/group/cilium/Start (gopogh)	15.79 (chart)
Docker_macOS	TestNetworkPlugins/group/enable-default-cni/Start (gopogh)	15.79 (chart)
Docker_macOS	TestNetworkPlugins/group/false/Start (gopogh)	15.79 (chart)
Docker_Linux	TestFunctional/serial/ComponentHealth (gopogh)	23.81 (chart)
Docker_macOS	TestNetworkPlugins/group/bridge/Start (gopogh)	24.21 (chart)
Docker_macOS	TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh)	26.79 (chart)
Docker_macOS	TestStartStop/group/default-k8s-different-port/serial/EnableAddonAfterStop (gopogh)	26.79 (chart)
Docker_macOS	TestStartStop/group/default-k8s-different-port/serial/EnableAddonWhileActive (gopogh)	26.79 (chart)
Docker_macOS	TestStartStop/group/default-k8s-different-port/serial/Stop (gopogh)	26.79 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/DeployApp (gopogh)	26.79 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/EnableAddonAfterStop (gopogh)	26.79 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

AkihiroSuda · 2022-03-09T03:47:28Z

CI failures are unrelated

https://storage.googleapis.com/minikube-builds/logs/12901/22700/Docker_macOS.html#fail_TestSkaffold

unable to stream build output: Head "https://registry-1.docker.io/v2/library/alpine/manifests/3.10": Get "https://auth.docker.io/token?scope=repository%3Alibrary%2Falpine%3Apull&service=registry.docker.io": net/http: request canceled (Client.Timeout exceeded while awaiting headers). Please fix the Dockerfile and try again..

https://storage.googleapis.com/minikube-builds/logs/12901/22700/KVM_Linux.html#fail_TestNoKubernetes/serial/ProfileList

E0217 21:54:30.300518 27885 status.go:413] kubeconfig endpoint: extract IP: "NoKubernetes-20220217214930-8463" does not appear in /home/jenkins/minikube-integration/linux-amd64-kvm2--12901-4847-633f3037c0c0f526c8a6275863415ef92a6e467e/kubeconfig

Usage: `minikube start --driver=podman --rootless --container-runtime=(cri-o|containerd)` Tested on Podman 3.4.1, Ubuntu 21.10. Needs cgroup v2 (as in Rootless Docker): https://rootlesscontaine.rs/getting-started/common/cgroup2/ See also `site/content/en/docs/drivers/includes/podman_usage.inc` Fix issue 8719 Fix issue 12460 Signed-off-by: Akihiro Suda <[email protected]>

AkihiroSuda · 2022-03-15T06:35:25Z

Rebased

minikube-pr-bot · 2022-03-15T07:26:17Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12901) |
+----------------+----------+---------------------+
| minikube start | 53.6s    | 52.2s               |
| enable ingress | 28.3s    | 28.1s               |
+----------------+----------+---------------------+

Times for minikube ingress: 28.5s 29.1s 25.1s 29.1s 30.0s
Times for minikube (PR 12901) ingress: 28.6s 29.1s 26.6s 29.5s 26.6s

Times for minikube start: 53.3s 55.2s 52.5s 54.6s 52.5s
Times for minikube (PR 12901) start: 52.9s 52.1s 52.6s 51.2s 52.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12901) |
+----------------+----------+---------------------+
| minikube start | 27.1s    | 26.1s               |
| enable ingress | 23.0s    | 23.0s               |
+----------------+----------+---------------------+

Times for minikube start: 30.3s 25.9s 26.9s 25.8s 26.6s
Times for minikube (PR 12901) start: 25.7s 26.1s 26.1s 26.8s 25.9s

Times for minikube ingress: 23.9s 21.9s 21.9s 24.0s 23.4s
Times for minikube (PR 12901) ingress: 24.0s 22.4s 22.9s 22.9s 22.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12901) |
+----------------+----------+---------------------+
| minikube start | 39.1s    | 42.2s               |
| enable ingress | 29.4s    | 28.7s               |
+----------------+----------+---------------------+

Times for minikube start: 30.8s 41.2s 40.7s 40.4s 42.6s
Times for minikube (PR 12901) start: 41.0s 41.2s 41.8s 45.3s 41.6s

Times for minikube ingress: 23.4s 23.4s 23.4s 53.4s 23.4s
Times for minikube (PR 12901) ingress: 54.4s 23.4s 23.4s 19.0s 23.4s

minikube-pr-bot · 2022-03-15T09:07:26Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_macOS	TestDownloadOnly/v1.23.4-rc.0/preload-exists (gopogh)	0.00 (chart)
KVM_Linux	TestStartStop/group/old-k8s-version/serial/Pause (gopogh)	1.27 (chart)
Docker_Linux_containerd	TestPause/serial/Pause (gopogh)	2.48 (chart)
Docker_macOS	TestDownloadOnlyKic (gopogh)	8.57 (chart)
Docker_macOS	TestDownloadOnly/v1.23.3/preload-exists (gopogh)	8.57 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/EnableAddonAfterStop (gopogh)	9.62 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/Stop (gopogh)	9.62 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/AddonExistsAfterStop (gopogh)	10.48 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/UserAppExistsAfterStop (gopogh)	10.48 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/SecondStart (gopogh)	11.32 (chart)
Docker_Linux	TestNetworkPlugins/group/kindnet/Start (gopogh)	40.13 (chart)
Docker_macOS	TestFunctional/serial/ComponentHealth (gopogh)	43.57 (chart)
Docker_macOS	TestFunctional/serial/ExtraConfig (gopogh)	43.57 (chart)
Docker_macOS	TestNetworkPlugins/group/calico/Start (gopogh)	58.06 (chart)
Docker_macOS	TestNetworkPlugins/group/kindnet/Start (gopogh)	60.48 (chart)
Docker_macOS	TestNetworkPlugins/group/kubenet/DNS (gopogh)	60.66 (chart)
Docker_Linux	TestNetworkPlugins/group/custom-weave/Start (gopogh)	62.50 (chart)
Docker_Cloud_Shell	TestAddons/parallel/MetricsServer (gopogh)	68.81 (chart)
Hyper-V_Windows	TestNoKubernetes/serial/StartWithK8s (gopogh)	71.11 (chart)
Docker_Linux	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	73.68 (chart)
Docker_macOS	TestNetworkPlugins/group/bridge/DNS (gopogh)	75.00 (chart)
Docker_Linux	TestNetworkPlugins/group/bridge/DNS (gopogh)	75.66 (chart)
Docker_macOS	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	76.85 (chart)
Docker_Linux	TestNetworkPlugins/group/kubenet/DNS (gopogh)	77.63 (chart)
Docker_Linux	TestNetworkPlugins/group/calico/Start (gopogh)	78.29 (chart)
Docker_macOS	TestDownloadOnly/v1.16.0/preload-exists (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/RestartKeepsNodes (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

k8s-ci-robot · 2022-03-16T23:35:06Z

@AkihiroSuda: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

AkihiroSuda · 2022-03-22T04:58:53Z

~~Maybe we should create a separate --driver=podman-rootless and remove --rootless flag?~~ (EDIT: tried but seem too much complicated)

AkihiroSuda · 2022-03-22T09:36:07Z

New PR:

Support rootless Podman driver, take 2 (Usage: minikube config set rootless true) #13829

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 9, 2021

k8s-ci-robot requested review from blueelvis and prasadkatti November 9, 2021 08:30

This was referenced Nov 9, 2021

rootless podman driver #8719

Closed

Remove hardcoded sudo from commands and make it conditional #12460

Closed

AkihiroSuda force-pushed the rootless-podman branch from 6482ea9 to 40e5461 Compare November 9, 2021 09:17

medyagh requested changes Nov 12, 2021

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2021

AkihiroSuda force-pushed the rootless-podman branch from 40e5461 to 65f4a51 Compare November 12, 2021 05:15

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2021

AkihiroSuda changed the title ~~Support rootless Podman driver ( minikube start --driver=podman --rootless --container-runtime=containerd)~~ Support rootless Podman driver ( minikube start --driver=podman --rootless --container-runtime=(cri-o|containerd)) Nov 12, 2021

AkihiroSuda force-pushed the rootless-podman branch from 65f4a51 to 7eba4c5 Compare November 12, 2021 05:18

AkihiroSuda requested a review from medyagh November 16, 2021 11:22

AkihiroSuda force-pushed the rootless-podman branch from 7eba4c5 to e9f6858 Compare November 30, 2021 09:25

AkihiroSuda mentioned this pull request Dec 2, 2021

Run podman as USER then as sudo in driver check #13061

Closed

medyagh approved these changes Dec 7, 2021

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2021

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 7, 2021

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2022

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2022

AkihiroSuda force-pushed the rootless-podman branch from 678a94f to 58d33b5 Compare February 3, 2022 06:10

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2022

afbjorklund mentioned this pull request Feb 9, 2022

minikube with podman on macOS darwin/amd64 doesn't work #12658

Closed

AkihiroSuda force-pushed the rootless-podman branch from 58d33b5 to 633f303 Compare February 16, 2022 04:57

AkihiroSuda requested review from medyagh and afbjorklund March 9, 2022 03:47

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 15, 2022

AkihiroSuda force-pushed the rootless-podman branch from 633f303 to 2bbf53a Compare March 15, 2022 06:35

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 15, 2022

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2022

AkihiroSuda mentioned this pull request Mar 22, 2022

Support rootless Podman driver, take 2 (Usage: minikube config set rootless true) #13829

Merged

AkihiroSuda closed this Mar 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support rootless Podman driver ( `minikube start --driver=podman --rootless --container-runtime=(cri-o|containerd)`) #12901

Support rootless Podman driver ( `minikube start --driver=podman --rootless --container-runtime=(cri-o|containerd)`) #12901

AkihiroSuda commented Nov 9, 2021 •

edited

Loading

minikube-bot commented Nov 9, 2021

medyagh left a comment

medyagh Nov 12, 2021

AkihiroSuda Nov 12, 2021 •

edited

Loading

medyagh Dec 7, 2021

AkihiroSuda commented Nov 19, 2021

medyagh left a comment

medyagh commented Dec 7, 2021

minikube-pr-bot commented Dec 8, 2021

minikube-pr-bot commented Dec 8, 2021

sharifelgamal commented Dec 13, 2021

minikube-pr-bot commented Dec 14, 2021

minikube-pr-bot commented Dec 14, 2021

AkihiroSuda commented Dec 23, 2021 •

edited

Loading

AkihiroSuda commented Jan 13, 2022

AkihiroSuda commented Feb 3, 2022

minikube-pr-bot commented Feb 3, 2022

minikube-pr-bot commented Feb 3, 2022

AkihiroSuda commented Feb 7, 2022

minikube-pr-bot commented Feb 16, 2022

minikube-pr-bot commented Feb 16, 2022

sharifelgamal commented Feb 17, 2022

minikube-pr-bot commented Feb 17, 2022

minikube-pr-bot commented Feb 17, 2022

AkihiroSuda commented Mar 9, 2022

AkihiroSuda commented Mar 15, 2022

minikube-pr-bot commented Mar 15, 2022

minikube-pr-bot commented Mar 15, 2022

k8s-ci-robot commented Mar 16, 2022

AkihiroSuda commented Mar 22, 2022 •

edited

Loading

AkihiroSuda commented Mar 22, 2022

Support rootless Podman driver ( minikube start --driver=podman --rootless --container-runtime=(cri-o|containerd)) #12901

Support rootless Podman driver ( minikube start --driver=podman --rootless --container-runtime=(cri-o|containerd)) #12901

Conversation

AkihiroSuda commented Nov 9, 2021 • edited Loading

minikube-bot commented Nov 9, 2021

medyagh left a comment

Choose a reason for hiding this comment

medyagh Nov 12, 2021

Choose a reason for hiding this comment

AkihiroSuda Nov 12, 2021 • edited Loading

Choose a reason for hiding this comment

medyagh Dec 7, 2021

Choose a reason for hiding this comment

AkihiroSuda commented Nov 19, 2021

medyagh left a comment

Choose a reason for hiding this comment

medyagh commented Dec 7, 2021

minikube-pr-bot commented Dec 8, 2021

minikube-pr-bot commented Dec 8, 2021

sharifelgamal commented Dec 13, 2021

minikube-pr-bot commented Dec 14, 2021

minikube-pr-bot commented Dec 14, 2021

AkihiroSuda commented Dec 23, 2021 • edited Loading

AkihiroSuda commented Jan 13, 2022

AkihiroSuda commented Feb 3, 2022

minikube-pr-bot commented Feb 3, 2022

minikube-pr-bot commented Feb 3, 2022

AkihiroSuda commented Feb 7, 2022

minikube-pr-bot commented Feb 16, 2022

minikube-pr-bot commented Feb 16, 2022

sharifelgamal commented Feb 17, 2022

minikube-pr-bot commented Feb 17, 2022

minikube-pr-bot commented Feb 17, 2022

AkihiroSuda commented Mar 9, 2022

AkihiroSuda commented Mar 15, 2022

minikube-pr-bot commented Mar 15, 2022

minikube-pr-bot commented Mar 15, 2022

k8s-ci-robot commented Mar 16, 2022

AkihiroSuda commented Mar 22, 2022 • edited Loading

AkihiroSuda commented Mar 22, 2022

Support rootless Podman driver ( `minikube start --driver=podman --rootless --container-runtime=(cri-o|containerd)`) #12901

Support rootless Podman driver ( `minikube start --driver=podman --rootless --container-runtime=(cri-o|containerd)`) #12901

AkihiroSuda commented Nov 9, 2021 •

edited

Loading

AkihiroSuda Nov 12, 2021 •

edited

Loading

AkihiroSuda commented Dec 23, 2021 •

edited

Loading

AkihiroSuda commented Mar 22, 2022 •

edited

Loading