Roll back default crio cgroup to systemd

[spowelljr]

Fixes #12509

So in the point release from v1.23.0 -> v1.23.1 I updated cri-o from v1.20 -> v1.22.

Unknown to us, a PR titled "crio config" only prints the fields that are differet than the default was included in the v1.22 release of cri-o. cri-o has the default cgroup manager set to systemd so if the system uses systemd it no longer outputs it in the crio config.

For minikube to know what cgroup to use for minikube, we default to cgroupfs and then parse the output of crio config to determine what to use. The new version of crio was omitting outputting systemd as the cgroup manager since it's the default, we had nothing to parse and were using our default of cgroupfs instead.

crio v1.20 (423 lines of config)

$ crio config | wc -l
423
$ crio config | grep "cgroup_manager"
cgroup_manager = "systemd"

crio v1.22 (88 lines of config)

$ crio config | wc -l
88
$ crio config | grep "cgroup_manager"
# no output

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[medyagh]

please lets paste the two config files one from minikube 1.23.0 and one from 1.23.1 and explain why cri-o needs systemd ...what is the default for containerd?

[spowelljr]

/ok-to-test

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12533) |
+----------------+----------+---------------------+
| minikube start | 49.1s    | 48.6s               |
| enable ingress | 34.3s    | 32.3s               |
+----------------+----------+---------------------+

Times for minikube start: 50.8s 47.6s 49.9s 49.1s 48.1s
Times for minikube (PR 12533) start: 49.0s 49.2s 47.8s 47.4s 49.6s

Times for minikube ingress: 34.4s 33.4s 32.4s 39.3s 31.9s
Times for minikube (PR 12533) ingress: 32.3s 32.3s 32.3s 32.3s 32.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12533) |
+----------------+----------+---------------------+
| minikube start | 22.3s    | 21.9s               |
| enable ingress | 29.8s    | 29.4s               |
+----------------+----------+---------------------+

Times for minikube start: 22.7s 21.8s 21.7s 22.8s 22.3s
Times for minikube (PR 12533) start: 20.8s 21.9s 22.8s 21.4s 22.5s

Times for minikube (PR 12533) ingress: 28.9s 26.9s 34.5s 28.4s 28.4s
Times for minikube ingress: 27.9s 26.5s 33.0s 26.4s 35.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12533) |
+----------------+----------+---------------------+
| minikube start | 40.5s    | 40.1s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 27.5s 44.3s 43.9s 43.5s 43.4s
Times for minikube (PR 12533) start: 43.9s 43.4s 25.4s 44.1s 43.5s

[minikube-pr-bot]

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd	TestScheduledStopUnix (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.