-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingress Addon] Fix bug which the networking.k8s.io/v1 ingress is always rejected #11189
Conversation
Hi @govargo. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @medyagh |
Can one of the admins verify this patch? |
…ValidatingWebhookConfiguration
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 55.6s 47.9s 51.9s 47.3s 50.5s Times for minikube ingress: 43.3s 42.9s 35.3s 36.3s 36.8s docker driver with docker runtime
Times for minikube ingress: 34.0s 33.0s 30.5s 31.0s 37.5s Times for minikube (PR 11189) start: 22.4s 22.0s 20.9s 21.8s 21.5s docker driver with containerd runtime |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: govargo, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Same issue with:
Log files:
|
What type of PR is this?
/kind bug
/addon ingress
/kind regression
/priority important-soon
What this PR does / why we need it:
This PR will fix the bug which the
networking.k8s.io/v1
ingress is alwalys rejected.As I described at #11121 (comment), upstream ingress-nginx(v0.44.0 and v0.45.0(latest)) doesn't allow
networking.k8s.io/v1
ingress.Ingress-nginx admission controller only support(validate)
networking.k8s.io/v1beta1
ingress.networking.k8s.io/v1
ingress is not supported(validated).But our ValidatingWebhookConfiguration manifest check both
networking.k8s.io/v1beta1
andnetworking.k8s.io/v1
.minikube/deploy/addons/ingress/ingress-dp.yaml.tmpl
Lines 196 to 200 in f854a08
I removed
networking.k8s.io/v1
check from ValidatingWebhookConfiguration manifest.And I add a integration test pattern to check if
networking.k8s.io/v1
ingress works.Which issue(s) this PR fixes:
Fix #11121
Does this PR introduce a user-facing change?
Yes. This PR allows to create
networking.k8s.io/v1
ingress.Before this PR
networking.k8s.io/v1
ingress is always rejected by Validating Webhook.After this PR
networking.k8s.io/v1
ingress can be created.Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: