-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature to opt-in to get notifications for beta releases #11169
Conversation
Can one of the admins verify this patch? |
dd3c370
to
2974543
Compare
Just realized that with the current logic, a older beta will take priority over a newer full release. Will resolve this conflict and add a test for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets change the get Names to proper go idiomatic and then looks good to me
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube (PR 11169) start: 47.2s 49.0s 48.4s 46.0s 49.0s Times for minikube ingress: 43.3s 37.8s 36.8s 41.8s 37.7s docker driver with docker runtime
Times for minikube start: 21.8s 22.4s 21.7s 21.6s 21.6s Times for minikube ingress: 32.5s 33.0s 30.0s 34.0s 33.5s docker driver with containerd runtime
Times for minikube start: 31.4s 43.5s 43.1s 43.5s 47.6s |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes #10328
Added a new config option that the user can enable to get notified of beta releases.
The user can opt-in with the following command:
Release script need to be updated to update the
releases-beta.json
file with the release version.