add minikube image rm command

[tharun208]

Fixes #10916

[k8s-ci-robot]

Hi @tharun208. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[tharun208]

@medyagh, do we need to have a separate test to remove images, or can we update the validateLoadImage to remove the loaded image?

[medyagh]

@tharun208 thanks for this PR, looks good, would u please add an integration test for it in the
FuncationalTest?
maybe after LoadImage https://github.com/medyagh/minikube/blob/9136127de65b2732a08d132954d09cb9aa90eba9/test/integration/functional_test.go#L135

[tharun208]

@medyagh I also see we have podman configured in the cruntime_test.go

minikube/pkg/minikube/cruntime/cruntime_test.go

Line 213 in 67e4035

case "podman":

As it is not supported in cruntime can we remove the podman related code from the test.

[afbjorklund]

can we remove the podman related code from the test.

We need the podman program, for the crio container runtime.

[medyagh]

/ok-to-test

[minikube-pr-bot]

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with minikube: timing cmd: [/home/performance-monitor/minikube/out/minikube start --driver=kvm2]: waiting for minikube: exit status 69
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10924): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10924/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10924/minikube: exec format error

[minikube-pr-bot]

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with minikube: timing cmd: [/home/performance-monitor/minikube/out/minikube start --driver=kvm2]: waiting for minikube: exit status 69
docker Driver
Times for minikube: 29.8s 35.5s 24.6s
Average time for minikube: 30.0s

Times for Minikube (PR 10924): 29.8s 25.9s 25.5s
Average time for Minikube (PR 10924): 27.1s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10924) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.2s     | 0.2s                |
| 9.11 (amd64)                               |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 13.4s    | 10.3s               |
| (CPUs=2, Memory=4000MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 15.1s    | 15.0s               |
| on Docker 20.10.3 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.0s     | 1.2s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, tharun208

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment