Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

status: Omit timeToStop if nonexistent #10906

Merged
merged 2 commits into from
Mar 25, 2021
Merged

status: Omit timeToStop if nonexistent #10906

merged 2 commits into from
Mar 25, 2021

Conversation

tharun208
Copy link
Contributor

Previously, in minikube status we show TimeToStop as NonExistent this pr introduces changes as instead of showing NonExistent it does not mention it in the status.

Before:
Screen Shot 2021-03-23 at 2 36 18 PM

After:
Screen Shot 2021-03-24 at 11 43 54 AM

Fixes: #10905

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 24, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @tharun208. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 24, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 24, 2021
@tharun208 tharun208 changed the title not mention timeToStop in status instead of showing NonExistent Not to mention timeToStop in status instead of showing NonExistent Mar 24, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@tharun208 tharun208 mentioned this pull request Mar 24, 2021
Closed
tharun208
tharun208 commented Mar 24, 2021
View reviewed changes
test/integration/scheduled_stop_test.go
@@ -69,8 +69,6 @@ func TestScheduledStopWindows(t *testing.T) {
time.Sleep(5 * time.Second)
// make sure minikube status is "Stopped"
ensureMinikubeStatus(ctx, t, profile, "Host", state.Stopped.String())
// make sure minikube timtostop is "Nonexistent"
ensureMinikubeStatus(ctx, t, profile, "TimeToStop", "Nonexistent")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@medyagh, what I am thinking is instead of removing this check from the test. Can we check for TimeToStop status value to be ""?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should check that the timeToStop line is omitted entirely.

@tstromberg tstromberg changed the title Not to mention timeToStop in status instead of showing NonExistent status: Omit timeToStop if nonexistent Mar 24, 2021
tstromberg
tstromberg suggested changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@tstromberg tstromberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks great! Please make sure the integration test is updated so that it would fail if this PR was reverted accidentally in the future.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 24, 2021
@medyagh
Copy link
Member

medyagh commented Mar 24, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 24, 2021
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10906): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10906/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10906/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10906): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10906/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10906/minikube: exec format error

@medyagh
Copy link
Member

medyagh commented Mar 24, 2021

@tharun208 could this test failure be related ? https://storage.googleapis.com/minikube-builds/logs/10906/c03b282/Docker_Linux.html#fail_TestErrorSpam%2fstatus

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, tharun208

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2021
@medyagh medyagh merged commit fe5f5d9 into kubernetes:master Mar 25, 2021
@tharun208 tharun208 deleted the feat/not_mention_timeToStop branch May 10, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@tstromberg tstromberg Awaiting requested review from tstromberg

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

minikube status: show timeToStop only if it exists
6 participants
@tharun208 @k8s-ci-robot @minikube-bot @medyagh @minikube-pr-bot @tstromberg