-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve kvm network delete/cleanup #10479
Conversation
Hi @prezha. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
a785552
to
a5f75b4
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, prezha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
this pr should further improve kvm private network delete/cleanup, like situations where the
--delete
flag leavesminikube-net
behind in inactive state after a failed start, or when such minikube-net cannot be reused on subsequentstart
simprovement on previous issues:
#9666
#9610
#9049
#8952
also potentially improves / fixes #10040
details:
before: we try to reactivate inactive net and then to destroy it (as inactive net cannot be destroyed)
after: transition states are:
example: #10439 (comment)
if this proves working as expected in practice, we would probably be able to remove the repeat/retry wrapper as not needed
note: i remember that we ask users to provide output of
virsh net-list
to troubleshoot issues - we should ask forvirsh net-list --all
instead, as otherwise inactive nets will not be shown; also noting that the command should be run as root user, as regular user will probably not see any netsi've tried to locate those references in docs (around https://minikube.sigs.k8s.io/docs/drivers/kvm2/) and propose these changes, but couldn't find it :(