Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable all drivers except "docker" and "ssh" on darwin/arm64 #10452

Merged
merged 7 commits into from
Feb 12, 2021

Conversation

ilya-zuyev
Copy link
Contributor

Fixes #10120

This PR fixes the list of supported minikube drivers for darwin/arm64 platform.

Before:

develop@Devs-Mac-mini --- z/minikube ‹master› out/minikube start --driver=hyperkit                                                                                                                                    60 ↵
* minikube v1.17.1 on Darwin 11.1 (arm64)
* Using the hyperkit driver based on existing profile
* Starting control plane node minikube in cluster minikube
* Restarting existing hyperkit VM for "minikube" ...
! StartHost failed, but will try again: driver start: hyperkit crashed! command line:
  hyperkit loglevel=3 console=ttyS0 console=tty0 noembed nomodeset norestore waitusb=10 systemd.legacy_systemd_cgroup_controller=yes random.trust_cpu=on hw_rng_model=virtio base host=minikube
* Restarting existing hyperkit VM for "minikube" ...
* Failed to start hyperkit VM. Running "minikube delete" may fix it: driver start: hyperkit crashed! command line:
  hyperkit loglevel=3 console=ttyS0 console=tty0 noembed nomodeset norestore waitusb=10 systemd.legacy_systemd_cgroup_controller=yes random.trust_cpu=on hw_rng_model=virtio base host=minikube

X Exiting due to PR_HYPERKIT_CRASHED: Failed to start host: driver start: hyperkit crashed! command line:
  hyperkit loglevel=3 console=ttyS0 console=tty0 noembed nomodeset norestore waitusb=10 systemd.legacy_systemd_cgroup_controller=yes random.trust_cpu=on hw_rng_model=virtio base host=minikube
* Suggestion: Hyperkit is broken. Upgrade to the latest hyperkit version and/or Docker for Desktop. Alternatively, you may choose an alternate --driver
* Related issues:
  - https://github.com/kubernetes/minikube/issues/6079
  - https://github.com/kubernetes/minikube/issues/5780

After:

develop@Devs-Mac-mini --- z/minikube ‹ilyaz/disable_hyperv_on_m1› » out/minikube start --driver=hyperkit
* minikube v1.17.1 on Darwin 11.1 (arm64)
* Using the hyperkit driver based on user configuration

X Exiting due to DRV_UNSUPPORTED_OS: The driver 'hyperkit' is not supported on darwin/arm64

Translated messages fixed as well:

develop@Devs-Mac-mini --- z/minikube ‹ilyaz/disable_hyperv_on_m1› LC_ALL=fr out/minikube start --driver=hyperkit                                                                                                      56 ↵
* minikube v1.17.1 sur Darwin 11.1 (arm64)
* Utilisation du pilote hyperkit basé sur la configuration de l'utilisateur

X Exiting due to DRV_UNSUPPORTED_OS: Le pilote "hyperkit" n'est pas compatible avec darwin/arm64.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 11, 2021
@ilya-zuyev ilya-zuyev added arch/arm64 kind/bug Categorizes issue or PR as related to a bug. os/macos and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 11, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2021
@ilya-zuyev
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 11, 2021
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10452): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10452/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10452/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10452): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10452/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10452/minikube: exec format error

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @ilya-zuyev

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ilya-zuyev, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit 350f8a2 into kubernetes:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. arch/arm64 kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. os/macos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mac M1 minikube start failed - hyperkit
4 participants