Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly remove podman volume and network #10435

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

afbjorklund
Copy link
Collaborator

The --filter and --label functionality was broken,
in earlier versions of podman (before version 3.0)

Closes #9705

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 10, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 10, 2021
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good @afbjorklund , but needs rebase

pkg/drivers/kic/oci/volumes.go Show resolved Hide resolved
The --filter and --label functionality was broken,
in earlier versions of podman (before version 3.0)
@medyagh
Copy link
Member

medyagh commented Feb 10, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 10, 2021
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10435): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10435/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10435/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10435): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10435/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10435/minikube: exec format error

@medyagh medyagh merged commit 3512e88 into kubernetes:master Feb 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLasan
Copy link
Contributor

BLasan commented Feb 11, 2021

@afbjorklund Are we able to close the issue #10379 from this commit as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Podman driver doesn't remove volume or network on delete
5 participants