Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kic: add crun for running on cgroups v2 #10426

Merged
merged 2 commits into from
Feb 20, 2021
Merged

Conversation

afbjorklund
Copy link
Collaborator

Podman will default to crun, for v2 (runc for v1)

So these dependencies are needed for podman.service

Note that runc is now provided by "containerd.io"

As seen in #10182 (comment)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 9, 2021
@medyagh
Copy link
Member

medyagh commented Feb 20, 2021

ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @afbjorklund,

A new kicbase image is available, please update your PR with the new tag and SHA.
In pkg/drivers/kic/types.go:

// Version is the current version of kic
Version = "v0.0.17-1613804889-10426"
// SHA of the kic base image
baseImageSHA = "cf36df7461ff534165085317887318b45247005bae55ebaa75397f58c8c5deb3"
// The name of the GCR kicbase repository
gcrRepo = "gcr.io/k8s-minikube/kicbase-builds"
// The name of the Dockerhub kicbase repository
dockerhubRepo = "kicbase/build"

Then run make generate-docs to update our documentation to reference the new image.

Alternatively, run the following command and commit the changes:

 sed 's|Version = .*|Version = "v0.0.17-1613804889-10426"|;s|baseImageSHA = .*|baseImageSHA = "cf36df7461ff534165085317887318b45247005bae55ebaa75397f58c8c5deb3"|;s|gcrRepo = .*|gcrRepo = "gcr.io/k8s-minikube/kicbase-builds"|;s|dockerhubRepo = .*|dockerhubRepo = "kicbase/build"|' pkg/drivers/kic/types.go > new-types.go; mv new-types.go pkg/drivers/kic/types.go; make generate-docs;

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2021
@medyagh
Copy link
Member

medyagh commented Feb 20, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 20, 2021
@kubernetes kubernetes deleted a comment from minikube-pr-bot Feb 20, 2021
@medyagh medyagh changed the title Make sure to add crun for running on cgroups v2 kic: Make sure to add crun for running on cgroups v2 Feb 20, 2021
afbjorklund and others added 2 commits February 20, 2021 10:11
Podman will default to crun, for v2 (runc for v1)

So these dependencies are needed for podman.service

Note that runc is now provided by "containerd.io"
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 20, 2021
@medyagh medyagh merged commit 2da3c04 into kubernetes:master Feb 20, 2021
@medyagh medyagh changed the title kic: Make sure to add crun for running on cgroups v2 kic: add crun for running on cgroups v2 Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants