Upgrade spinner library #10399
Merged
Upgrade spinner library #10399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
kvm2 Driver |
afbjorklund
requested changes
Feb 8, 2021
afbjorklund
approved these changes
Feb 8, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, alonyb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Did you make a PR to upstream https://github.com/briandowns/spinner ? |
|
kvm2 Driver Times for Minikube (PR 10399): 66.9s 66.4s 65.9s Averages Time Per Log docker Driver Times for Minikube (PR 10399): 25.2s 24.6s 23.9s Averages Time Per Log |
@afbjorklund Yep, here is the link if you want to check it PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for #10338
Upgrade spinner library to avoid spinner in environments that is not a terminal, like files or IDE's.
Here is PR of spinner library link to check differences
In library we used go-isatty, suggested by @medyagh
I tested in unix systems and windows powershell. It works without problem.
Before fix
After fix
