Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metallb addon: fix configuration empty load balancing IP range #10395

Merged
merged 1 commit into from
Feb 8, 2021
Merged

metallb addon: fix configuration empty load balancing IP range #10395

merged 1 commit into from
Feb 8, 2021

Conversation

govargo
Copy link
Contributor

@govargo govargo commented Feb 7, 2021

What type of PR is this?

/kind bug
/area addons

What this PR does / why we need it:

This PR fixes the bug of minikube addons configure metallb.
Currently, when users execute minikube addons configure metallb first time, the load balancing IP range will be empty.
It's because minikube evaluates generate templated file, when minikube addons enable XXXX.
But, current flows of configuration are

  1. minikube addons enable metallb - template manifest evaluated with empty
  2. minikube addons configure metallb - set load balancing IP with empty

This PR fixes this.

Which issue(s) this PR fixes:

Fix #10307

Does this PR introduce a user-facing change?

Yes. This PR fixes metallb addon.

Before this PR (Load Balancing IPs are empty)

$ minikube addons enable metallb
$ minikube addons configure metallb
(Input IP range Start-End)
$ kubectl describe configmap config -n metallb-system
...
Data
====
config:
----
address-pools:
- name: default
  protocol: layer2
  addresses:
  - -

After this PR (Load Balancing IPs are set)

$ minikube addons enable metallb
$ minikube addons configure metallb
(Input IP range Start-End)
$ kubectl describe configmap config -n metallb-system
...
Data
====
config:
----
address-pools:
- name: default
  protocol: layer2
  addresses:
  - 192.168.1.10-192.168.1.30

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 7, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @govargo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: govargo
To complete the pull request process, please assign tstromberg after the PR has been reviewed.
You can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 7, 2021
@govargo
Copy link
Contributor Author

govargo commented Feb 7, 2021

/assign @tstromberg

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@medyagh
Copy link
Member

medyagh commented Feb 7, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 7, 2021
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10395): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10395/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10395/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10395): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10395/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10395/minikube: exec format error

@medyagh medyagh merged commit 1c8944f into kubernetes:master Feb 8, 2021
@medyagh
Copy link
Member

medyagh commented Feb 8, 2021

@govargo thank you for fixing this

@medyagh medyagh changed the title Fix configuration of the metallb with empty load balancing IP range metallb addon: fix configuration empty load balancing IP range Feb 8, 2021
@govargo govargo deleted the fix-metallb-addon branch February 13, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metallb addon is not setting the IP range
6 participants