ssh: validate the ssh-key parameter if given #10293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the old (2016) TODO* from docker-machine, and might help to troubleshoot #10289
* https://github.com/docker/machine/blob/bd45ab13d88c32a3dd701485983354514abc41fa/drivers/generic/generic.go#L114
BEFORE:
🤦 StartHost failed, but will try again: creating host: create: creating: usermod: NewSession: new client: new client: Error creating new native config from ssh using: vagrant, &{[] [/home/anders/.minikube/machines/minikube/bogus]}: ssh: no key found
AFTER:
precreate: SSH key does not parse: "/tmp/bogus": ssh: no key found