-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure the crictl yaml file to avoid the warning #10215
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @jiefenghe! |
Hi @jiefenghe. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
I signed it. Added a ticket to the CLA issue: https://jira.linuxfoundation.org/plugins/servlet/theme/portal/4/SUPPORT-3834 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, jiefenghe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
thank you very much for fixing this @jiefenghe would u plz sign the CLA so we can accept this contribution ? |
/check-cla |
I signed it. |
Sorry It's a mess now. I have signed the CLA. But my initial commit was linked to the wrong email. So I did |
feel free to reopen a new PR with right commit author. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jiefenghe thanks for fixing this!
We have a temporary fix which parses out the STDERR warning for one of our tests, could you also remove this code, and the comment above it, now that is is unnecessary?
minikube/test/integration/start_stop_delete_test.go
Lines 293 to 294 in 7de5bf7
index := strings.Index(stdout, "{") | |
stdout = stdout[index:] |
Thank you!
Opened a new PR with the update #10221 |
fixes #10175
Kubernetes doesn't require crictl for docker, until the cri-dockerd is in use.
Adding the /etc/crictl.yaml to avoid the crictl warning.
Tested locally.