Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure the crictl yaml file to avoid the warning #10215

Closed
wants to merge 4 commits into from
Closed

configure the crictl yaml file to avoid the warning #10215

wants to merge 4 commits into from

Conversation

jiefenghe
Copy link
Contributor

fixes #10175

Kubernetes doesn't require crictl for docker, until the cri-dockerd is in use.
Adding the /etc/crictl.yaml to avoid the crictl warning.
Tested locally.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 22, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @jiefenghe!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 22, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @jiefenghe. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@jiefenghe
Copy link
Contributor Author

jiefenghe commented Jan 22, 2021

I signed it.

Added a ticket to the CLA issue: https://jira.linuxfoundation.org/plugins/servlet/theme/portal/4/SUPPORT-3834

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, jiefenghe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2021
@medyagh
Copy link
Member

medyagh commented Jan 22, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 22, 2021
@medyagh
Copy link
Member

medyagh commented Jan 22, 2021

thank you very much for fixing this @jiefenghe would u plz sign the CLA so we can accept this contribution ?
https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/

@jiefenghe
Copy link
Contributor Author

/check-cla

@jiefenghe
Copy link
Contributor Author

I signed it.

@jiefenghe
Copy link
Contributor Author

thank you very much for fixing this @jiefenghe would u plz sign the CLA so we can accept this contribution ?
https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/

Sorry It's a mess now. I have signed the CLA. But my initial commit was linked to the wrong email. So I did git commit --amend --reset-author to update the email. And tried to push to my local branch. But looks like the issue is still not resolved.

@medyagh
Copy link
Member

medyagh commented Jan 22, 2021

thank you very much for fixing this @jiefenghe would u plz sign the CLA so we can accept this contribution ?
https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/

Sorry It's a mess now. I have signed the CLA. But my initial commit was linked to the wrong email. So I did git commit --amend --reset-author to update the email. And tried to push to my local branch. But looks like the issue is still not resolved.

feel free to reopen a new PR with right commit author.

Copy link

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jiefenghe thanks for fixing this!

We have a temporary fix which parses out the STDERR warning for one of our tests, could you also remove this code, and the comment above it, now that is is unnecessary?

index := strings.Index(stdout, "{")
stdout = stdout[index:]

Thank you!

@jiefenghe
Copy link
Contributor Author

Hey @jiefenghe thanks for fixing this!

We have a temporary fix which parses out the STDERR warning for one of our tests, could you also remove this code, and the comment above it, now that is is unnecessary?

index := strings.Index(stdout, "{")
stdout = stdout[index:]

Thank you!

Opened a new PR with the update #10221

@jiefenghe jiefenghe closed this Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
7 participants