Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Debug flaky parallel/DryRun #10129

Closed
wants to merge 8 commits into from

Conversation

lingsamuel
Copy link
Contributor

@lingsamuel lingsamuel commented Jan 12, 2021

Signed-off-by: Ling Samuel [email protected]

a debug PR, do not merge #9785

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 12, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @lingsamuel. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lingsamuel
To complete the pull request process, please assign afbjorklund after the PR has been reviewed.
You can assign the PR to them by writing /assign @afbjorklund in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 12, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

Signed-off-by: Ling Samuel <[email protected]>
@lingsamuel lingsamuel force-pushed the debug-flaky-dryrun branch 3 times, most recently from cbf03a5 to e88039c Compare January 12, 2021 09:21
Signed-off-by: Ling Samuel <[email protected]>
Signed-off-by: Ling Samuel <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 13, 2021
Signed-off-by: Ling Samuel <[email protected]>
Signed-off-by: Ling Samuel <[email protected]>
@medyagh
Copy link
Member

medyagh commented Jan 13, 2021

@lingsamuel thank you very much for taking this task, this is one of the most annoying flakes on windows and I would love to get to the bottom of it.

I wonder if you have acesss to a windows machine to try it locally ?
if not I could provide you with a Windows machine on Azure for testing, if needed please ping me on Slack, I will provide u credentials for our test machine

Signed-off-by: Ling Samuel <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 14, 2021
@lingsamuel
Copy link
Contributor Author

@medyagh Thanks! That's what I need, pinged on Slack.
(To verification: my Slack member ID is U01G6SGJQTA)

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 14, 2021
@lingsamuel lingsamuel force-pushed the debug-flaky-dryrun branch 5 times, most recently from 93d0ce9 to a940b82 Compare January 14, 2021 12:57
Signed-off-by: Ling Samuel <[email protected]>
@k8s-ci-robot
Copy link
Contributor

@lingsamuel: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2021
@medyagh
Copy link
Member

medyagh commented Mar 30, 2021

@lingsamuel any finding from this finding ? Could it be we just have to skip the part of the dry run test on windows that checks the exit code to be a specific code ?

It seems like the exits code as expected is still non 0 but the difference is in What Exact code it is (1 or 128(

@lingsamuel
Copy link
Contributor Author

Nothing found till now. The exit is abnormal and unstable, couldn't find any way to reproduce it stably.
And I am very sorry, recently I am not working on this, it's harder than what I thought and I am busy in real life.

@lingsamuel lingsamuel closed this Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants