-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Debug flaky parallel/DryRun #10129
Conversation
Hi @lingsamuel. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lingsamuel The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
Signed-off-by: Ling Samuel <[email protected]>
cbf03a5
to
e88039c
Compare
Signed-off-by: Ling Samuel <[email protected]>
e88039c
to
d1b3cf8
Compare
Signed-off-by: Ling Samuel <[email protected]>
447b58c
to
2a46076
Compare
Signed-off-by: Ling Samuel <[email protected]>
Signed-off-by: Ling Samuel <[email protected]>
b29011c
to
0147fb8
Compare
@lingsamuel thank you very much for taking this task, this is one of the most annoying flakes on windows and I would love to get to the bottom of it. I wonder if you have acesss to a windows machine to try it locally ? |
Signed-off-by: Ling Samuel <[email protected]>
@medyagh Thanks! That's what I need, pinged on Slack. |
93d0ce9
to
a940b82
Compare
Signed-off-by: Ling Samuel <[email protected]>
a940b82
to
d407619
Compare
Signed-off-by: Ling Samuel <[email protected]>
@lingsamuel: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@lingsamuel any finding from this finding ? Could it be we just have to skip the part of the dry run test on windows that checks the exit code to be a specific code ? It seems like the exits code as expected is still non 0 but the difference is in What Exact code it is (1 or 128( |
Nothing found till now. The exit is abnormal and unstable, couldn't find any way to reproduce it stably. |
Signed-off-by: Ling Samuel [email protected]
a debug PR, do not merge #9785