Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid race condition in bootstrap certs for parallel runs #10118

Merged
merged 8 commits into from
Jan 13, 2021
Merged

avoid race condition in bootstrap certs for parallel runs #10118

merged 8 commits into from
Jan 13, 2021

Conversation

azhao155
Copy link
Contributor

@azhao155 azhao155 commented Jan 9, 2021 •
edited by medyagh
Loading

This pr is create per cluster certs for docker-env. So in parallel testing, would fix race condition issue of getting certs.

closes #10107

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 9, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @azhao155. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 9, 2021
@azhao155
Copy link
Contributor Author

azhao155 commented Jan 9, 2021

send out pr to verify if it can fix the flakiness.

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@medyagh
Copy link
Member

medyagh commented Jan 9, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 9, 2021
@medyagh medyagh changed the title Fix flakiness of parallel docker-env test wip: Fix flakiness of parallel docker-env test Jan 9, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 9, 2021
@medyagh
Copy link
Member

medyagh commented Jan 10, 2021

On first test seems to be fixing the docker-env flake

@medyagh
Copy link
Member

medyagh commented Jan 10, 2021

/retest-this-please

1 similar comment
@medyagh
Copy link
Member

medyagh commented Jan 11, 2021

/retest-this-please

@lingsamuel lingsamuel mentioned this pull request Jan 13, 2021
Closed
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 13, 2021
medyagh
medyagh requested changes Jan 13, 2021
View reviewed changes
pkg/minikube/machine/client.go Outdated Show resolved Hide resolved
pkg/minikube/machine/client.go Outdated Show resolved Hide resolved
pkg/minikube/machine/client.go Outdated Show resolved Hide resolved
medyagh
medyagh requested changes Jan 13, 2021
View reviewed changes
pkg/minikube/machine/client.go Outdated Show resolved Hide resolved
pkg/minikube/machine/client.go Show resolved Hide resolved
medyagh
medyagh requested changes Jan 13, 2021
View reviewed changes
pkg/minikube/machine/client.go Outdated Show resolved Hide resolved
@medyagh medyagh changed the title wip: Fix flakiness of parallel docker-env test avoid race condition in bootstrap certs for parallel runs Jan 13, 2021
@medyagh medyagh self-requested a review January 13, 2021 19:46
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: azhao155, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit 31aa5c1 into kubernetes:master Jan 13, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2021
@medyagh medyagh mentioned this pull request Jan 14, 2021
Closed
@azhao155 azhao155 mentioned this pull request Jan 29, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@RA489 RA489 Awaiting requested review from RA489

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DockerEnv Test:
4 participants
@azhao155 @k8s-ci-robot @minikube-bot @medyagh