-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix "cache add" command error when not specifying :latest tag #10058
Conversation
Hi @lingsamuel. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
e2d235d
to
ea5c686
Compare
Can one of the admins verify this patch? |
/remove-kind bug |
/ok-to-test |
kvm2 Driver |
ea5c686
to
aac2d6c
Compare
Signed-off-by: Ling Samuel <[email protected]>
aac2d6c
to
b79ab3f
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lingsamuel, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-this-please |
Signed-off-by: Ling Samuel [email protected]
Fixes #10047, code from https://github.com/google/go-containerregistry/blob/6544cb07415a0b92dcc4079fdb13c4540f651e11/pkg/name/tag.go#L74-L84
/kind bug