-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use appropriate ClusterDomain value in kubeadm KubeletConfiguration #10049
Conversation
Hi @sadlil. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
/ok-to-test |
kvm2 Driver |
6af2c7e
to
8430197
Compare
thank you for this PR @sadlil |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, sadlil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #9881
User provided flag
--dns-domain
is only used in kubeadm network configurations. Kubelet clusterDomian is always set to cluster.local and that results in broken dns resolving for service names likekube-dns.kube-system
. This PR uses the value of the flag for clusterDomain if provided or else defaults to cluster.local.According to https://github.com/kubernetes/kubernetes/blob/cea1d4e20b4a7886d8ff65f34c6d4f95efcb4742/pkg/kubelet/apis/config/types.go#L164 ClusterDomain should be same as DNSDomain for the cluster.