Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inner docker reload command #10027

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

azhao155
Copy link
Contributor

@azhao155 azhao155 commented Dec 23, 2020

zyanshu@zyanshukvm:~/minikube$ ./out/minikube start -p p1
πŸ˜„  [p1] minikube v1.16.0 on Debian rodete
✨  Automatically selected the docker driver
πŸ‘  Starting control plane node p1 in cluster p1
πŸ”₯  Creating docker container (CPUs=2, Memory=26100MB) ...
🐳  Preparing Kubernetes v1.20.0 on Docker 20.10.0 ...
    β–ͺ Generating certificates and keys ...
    β–ͺ Booting up control plane ...
    β–ͺ Configuring RBAC rules ...
πŸ”Ž  Verifying Kubernetes components...
🌟  Enabled addons: storage-provisioner, default-storageclass
πŸ„  Done! kubectl is now configured to use "p1" cluster and "default" namespace by default
zyanshu@zyanshukvm:~/minikube$ ./out/minikube ssh -p p1
docker@p1:~$ cat /lib/systemd/system/docker.service
[Unit]
Description=Docker Application Container Engine
Documentation=https://docs.docker.com
BindsTo=containerd.service
After=network-online.target firewalld.service containerd.service
Wants=network-online.target
Requires=docker.socket

[Service]
Type=notify
Restart=on-failure
StartLimitBurst=3
StartLimitIntervalSec=60



# This file is a systemd drop-in unit that inherits from the base dockerd configuration.
# The base configuration already specifies an 'ExecStart=...' command. The first directive
# here is to clear out that command inherited from the base configuration. Without this,
# the command from the base configuration and the command specified here are treated as
# a sequence of commands, which is not the desired behavior, nor is it valid -- systemd
# will catch this invalid input and refuse to start the service with an error like:
#  Service has more than one ExecStart= setting, which is only allowed for Type=oneshot services.

# NOTE: default-ulimit=nofile is set to an arbitrary number for consistency with other
# container runtimes. If left unlimited, it may result in OOM issues with MySQL.
ExecStart=
ExecStart=/usr/bin/dockerd -H tcp://0.0.0.0:2376 -H unix:///var/run/docker.sock --default-ulimit=nofile=1048576:1048576 --tlsverify --tlscacert /etc/docker/ca.pem --tlscert /etc/docker/server.pem
--tlskey /etc/docker/server-key.pem --label provider=docker --insecure-registry 10.96.0.0/12
ExecReload=/bin/kill -s HUP $MAINPID

# Having non-zero Limit*s causes performance problems due to accounting overhead
# in the kernel. We recommend using cgroups to do container-local accounting.
.....

docker@p1:~$ sudo systemctl reload docker
docker@p1:~$ docker ps
CONTAINER ID   IMAGE                  COMMAND                  CREATED              STATUS              PORTS     NAMES
05d0d07135a0   85069258b98a           "/storage-provisioner"   49 seconds ago       Up 48 seconds                 k8s_storage-provisioner_storage-provisioner_kube-system_1f5f1824-a7f5-444e-bab3-a3
b9d0635456_1
9507d432e824   bfe3a36ebd25           "/coredns -conf /etc…"   About a minute ago   Up About a minute             k8s_coredns_coredns-74ff55c5b-hmbn7_kube-system_945b813a-ca8b-4811-80fa-7891f209cd
f0_0
744a252e879f   10cc881966cf           "/usr/local/bin/kube…"   About a minute ago   Up About a minute             k8s_kube-proxy_kube-proxy-46grz_kube-system_8efca21b-2e9b-4828-b523-e28621a048df_0
fb7f52703b06   k8s.gcr.io/pause:3.2   "/pause"                 About a minute ago   Up About a minute             k8s_POD_coredns-74ff55c5b-hmbn7_kube-system_945b813a-ca8b-4811-80fa-7891f209cdf0_0
a9af4d429ffc   k8s.gcr.io/pause:3.2   "/pause"                 About a minute ago   Up About a minute             k8s_POD_kube-proxy-46grz_kube-system_8efca21b-2e9b-4828-b523-e28621a048df_0
45cbbef7b365   k8s.gcr.io/pause:3.2   "/pause"                 About a minute ago   Up About a minute             k8s_POD_storage-provisioner_kube-system_1f5f1824-a7f5-444e-bab3-a3b9d0635456_0
9e65fc1a0373   3138b6e3d471           "kube-scheduler --au…"   About a minute ago   Up About a minute             k8s_kube-scheduler_kube-scheduler-p1_kube-system_3478da2c440ba32fb6c087b3f3b99813_
0
4d95b42fe8a0   ca9843d3b545           "kube-apiserver --ad…"   About a minute ago   Up About a minute             k8s_kube-apiserver_kube-apiserver-p1_kube-system_524cecac593a7ad14f29307cb61f56b8_
0
5499344bc5b2   b9fa1895dcaa           "kube-controller-man…"   About a minute ago   Up About a minute             k8s_kube-controller-manager_kube-controller-manager-p1_kube-system_a3e7be694ef7cf9
52503c5d331abc0ac_0
9c112272eac0   0369cf4303ff           "etcd --advertise-cl…"   About a minute ago   Up About a minute             k8s_etcd_etcd-p1_kube-system_b428d92493177474d4f20b2e4a888f6f_0
559ceb493135   k8s.gcr.io/pause:3.2   "/pause"                 About a minute ago   Up About a minute             k8s_POD_kube-scheduler-p1_kube-system_3478da2c440ba32fb6c087b3f3b99813_0
d0fc3258463f   k8s.gcr.io/pause:3.2   "/pause"                 About a minute ago   Up About a minute             k8s_POD_kube-controller-manager-p1_kube-system_a3e7be694ef7cf952503c5d331abc0ac_0
63ce8571eae2   k8s.gcr.io/pause:3.2   "/pause"                 About a minute ago   Up About a minute             k8s_POD_kube-apiserver-p1_kube-system_524cecac593a7ad14f29307cb61f56b8_0
ad96084bfdd6   k8s.gcr.io/pause:3.2   "/pause"                 About a minute ago   Up About a minute             k8s_POD_etcd-p1_kube-system_b428d92493177474d4f20b2e4a888f6f_0

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 23, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @azhao155. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: azhao155
To complete the pull request process, please assign priyawadhwa after the PR has been reviewed.
You can assign the PR to them by writing /assign @priyawadhwa in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@azhao155
Copy link
Contributor Author

@medyagh

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@medyagh
Copy link
Member

medyagh commented Dec 23, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 23, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10027): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10027/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10027/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10027): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10027/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10027/minikube: exec format error

@medyagh medyagh merged commit a962466 into kubernetes:master Dec 23, 2020
@medyagh medyagh changed the title Fix docker reload issue in docker-env cmd Fix inner docker reload command Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants