Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not auto-select Hyper-V driver if session has no privilege #9396

Closed
tstromberg opened this issue Oct 5, 2020 · 4 comments · Fixed by #9588
Closed

Do not auto-select Hyper-V driver if session has no privilege #9396

tstromberg opened this issue Oct 5, 2020 · 4 comments · Fixed by #9588
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. ux/embedded Embedded UX blockers
Milestone

Comments

@tstromberg
Copy link
Contributor

We need to copy the logic from this check into the hyper-v driver health check, so that Hyper-V isn't accidentally selected when the user does not actually have the privilege to use it:

X Exiting due to PR_HYPERV_AS_ADMIN: Failed to start host: creating host: create: precreate: Hyper-v commands have to be run as an Administrator
* Suggestion: Right-click the PowerShell icon and select Run as Administrator to open PowerShell in elevated mode.

I suggest an error message like: "Hyper-V requires elevated privileges: Right-click the PowerShell icon and select Run as Administrator to use minikube with the Hyper-V driver`

@tstromberg tstromberg added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Oct 5, 2020
@tstromberg tstromberg added this to the v1.15.0-candidate milestone Oct 5, 2020
@tstromberg tstromberg changed the title hyperv: Do not select for auto-detection if there are no privileges Do not auto-select Hyper-V driver if session has no priviliges Oct 5, 2020
@tstromberg
Copy link
Contributor Author

/cc @medyagh @sharifelgamal

@tstromberg tstromberg added kind/bug Categorizes issue or PR as related to a bug. ux/embedded Embedded UX blockers labels Oct 5, 2020
@tstromberg tstromberg changed the title Do not auto-select Hyper-V driver if session has no priviliges Do not auto-select Hyper-V driver if session has no privilege Oct 5, 2020
@blueelvis
Copy link
Contributor

Picking this up.

/assign

@medyagh
Copy link
Member

medyagh commented Oct 27, 2020

@blueelvis are you still working on this ? we will need to implement this feature please let me know if you don't have time for it so I can re-assign

@blueelvis
Copy link
Contributor

blueelvis commented Oct 28, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. ux/embedded Embedded UX blockers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants