Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: move storage-provisioner out of the minikube go.mod #7638

Closed
medyagh opened this issue Apr 13, 2020 · 7 comments
Closed

cleanup: move storage-provisioner out of the minikube go.mod #7638

medyagh opened this issue Apr 13, 2020 · 7 comments
Labels
addon/storage-provisioner Issues relating to storage provisioner addon area/build-release kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@medyagh
Copy link
Member

medyagh commented Apr 13, 2020

while doing this PR #7636

I was trying to bump minikube kuberentes version lib to latest but /kubernetes-sigs/sig-storage-lib-external-provisioner uses an older client-go that we can not bump to latest.

however kubernetes-sigs/sig-storage-lib-external-provisioner is only used by pkg/storage/ which is only used by our storage-provisioner in cmd. which its own binary in a docker file

how about we remove storage privsioner outside minikube go mod and have its own go mod.
I bet that would make our binary size smaller too.

kubernetes-sigs/sig-storage-lib-external-provisioner#74

WARN [runner] Can't run linter goanalysis_metalinter: S1037: failed prerequisites: [([email protected]/minikube/pkg/storage, [email protected]/minikube/pkg/storage): analysis skipped: errors in package: [/Users/medmac/workspace/minikube/pkg/storage/storage_provisioner.go:33:2: could not import sigs.k8s.io/sig-storage-lib-external-provisioner/controller (/Users/medmac/go/pkg/mod/sigs.k8s.io/[email protected]+incompatible/controller/controller.go:55:2: could not import sigs.k8s.io/sig-storage-lib-external-provisioner/util (/Users/medmac/go/pkg/mod/sigs.k8s.io/[email protected]+incompatible/util/util.go:106:71: cannot use "coredns" (constant of type string) as context.Context value in argument to client.CoreV1().Services(metav1.NamespaceSystem).Get: missing method Deadline))]] 

what do you think @afbjorklund

@medyagh medyagh mentioned this issue Apr 13, 2020
@afbjorklund
Copy link
Collaborator

Maybe we should move the entire storage-provisioner out of the minikube git repository ?

It hasn't seen a new release in years, and like you say it seems to be mixing up the code.

@afbjorklund afbjorklund added addon/storage-provisioner Issues relating to storage provisioner addon area/build-release labels Apr 13, 2020
@afbjorklund
Copy link
Collaborator

afbjorklund commented Apr 13, 2020

I think it is also broken at the moment, there seem to be some reports about it not working ?

Like #7218 and #6523

@tstromberg tstromberg added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 15, 2020
@medyagh
Copy link
Member Author

medyagh commented Apr 16, 2020

I dont think we have capactiy for doing this at the moment. may be long term !

@medyagh medyagh added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Apr 16, 2020
@medyagh medyagh changed the title move storage-provisioner out of the minikube go.mod cleanup: move storage-provisioner out of the minikube go.mod Apr 16, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 15, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 14, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon/storage-provisioner Issues relating to storage provisioner addon area/build-release kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

5 participants