-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: move storage-provisioner out of the minikube go.mod #7638
Comments
Maybe we should move the entire storage-provisioner out of the minikube git repository ? It hasn't seen a new release in years, and like you say it seems to be mixing up the code. |
I dont think we have capactiy for doing this at the moment. may be long term ! |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
while doing this PR #7636
I was trying to bump minikube kuberentes version lib to latest but /kubernetes-sigs/sig-storage-lib-external-provisioner uses an older client-go that we can not bump to latest.
however kubernetes-sigs/sig-storage-lib-external-provisioner is only used by pkg/storage/ which is only used by our storage-provisioner in cmd. which its own binary in a docker file
how about we remove storage privsioner outside minikube go mod and have its own go mod.
I bet that would make our binary size smaller too.
kubernetes-sigs/sig-storage-lib-external-provisioner#74
what do you think @afbjorklund
The text was updated successfully, but these errors were encountered: