Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile list should not return error if one cluster is not ready #6851

Closed
medyagh opened this issue Mar 1, 2020 · 0 comments · Fixed by #6882
Closed

Profile list should not return error if one cluster is not ready #6851

medyagh opened this issue Mar 1, 2020 · 0 comments · Fixed by #6882
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@medyagh
Copy link
Member

medyagh commented Mar 1, 2020 •
edited
Loading

As seen in this test

https://storage.googleapis.com/minikube-builds/logs/6845/d6e4143/VirtualBox_Linux.html#fail_TestFunctional%2fparallel%2fProfileCmd%2fprofile_list

--- FAIL: TestFunctional/parallel/ProfileCmd/profile_list (0.21s)
functional_test.go:540: (dbg) Run:  out/minikube-linux-amd64 profile list
functional_test.go:540: (dbg) Non-zero exit: out/minikube-linux-amd64 profile list: exit status 78 (208.745917ms)
-- stdout --
|----------------------------------------------|------------|------------|----------------|------|----------|---------|
|                   Profile                    | VM Driver  |  Runtime   |       IP       | Port | Version  | Status  |
|----------------------------------------------|------------|------------|----------------|------|----------|---------|
| containerd-20200301T065612.372950053-30423   | virtualbox | containerd |                | 8444 | v1.17.3  |         |
| crio-20200301T065612.372967901-30423         | virtualbox | crio       |                | 8443 | v1.15.7  |         |
| docker-flags-20200301T065612.372493601-30423 | virtualbox | docker     |                | 8443 | v1.17.3  |         |
| functional-20200301T065430.272841444-30423   | virtualbox | docker     | 192.168.99.250 | 8443 | v1.17.3  | Running |
| newest-cni-20200301T065612.373103701-30423   | virtualbox | docker     |                | 8443 | v1.17.3  |         |
| old-docker-20200301T065612.372806255-30423   | virtualbox | docker     |                | 8443 | v1.11.10 |         |
|----------------------------------------------|------------|------------|----------------|------|----------|---------|
-- /stdout --
** stderr ** 
X error loading profiles: state: machine does not exist
** /stderr **
functional_test.go:542: [out/minikube-linux-amd64 profile list] failed: exit status 78
@medyagh medyagh added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Mar 2, 2020
@nkprince007 nkprince007 mentioned this issue Mar 4, 2020
Merged
nkprince007 added a commit to nkprince007/minikube that referenced this issue Mar 4, 2020
@nkprince007
profile_list: Do not throw error for unready clusters
ec78e13 
Fixes kubernetes#6851
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

profile list: exit zero even if one profile is not ready nkprince007/minikube
1 participant
@medyagh