Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Test: measure start a stopped minikube #6040

Closed
medyagh opened this issue Dec 9, 2019 · 6 comments
Closed

Performance Test: measure start a stopped minikube #6040

medyagh opened this issue Dec 9, 2019 · 6 comments
Assignees
Labels
area/performance Performance related issues kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@medyagh
Copy link
Member

medyagh commented Dec 9, 2019

while working on this PR https://github.com/kubernetes/minikube/pull/5987/files

I noticed my mprovements might have added 10 seconds to minikube "re-start" but to verify I had to do manual testing.
I purpose we measure, how a PR affects miikube start after a stop.

to do that:

  • minikube start;
    measure as before
  • minikube stop
    measure stop also
  • minikube start
    measure the start existing
@medyagh medyagh added the area/performance Performance related issues label Dec 10, 2019
@medyagh
Copy link
Member Author

medyagh commented Dec 10, 2019

Here is example in this PR comment.
#5987 (comment)

@tstromberg tstromberg added priority/backlog Higher priority than priority/awaiting-more-evidence. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels Dec 16, 2019
@medyagh
Copy link
Member Author

medyagh commented Dec 16, 2019

CC @priyawadhwa

@medyagh medyagh changed the title Performance Test: measure start existing minikube Performance Test: measure start stop minikube Dec 16, 2019
@medyagh medyagh changed the title Performance Test: measure start stop minikube Performance Test: measure start a stopped minikube Dec 16, 2019
@tstromberg tstromberg added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 19, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 18, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 17, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance Performance related issues kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

5 participants