Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: minikube should not crash if service or namespace doesn't exist. #5836

Closed
bjkowalski opened this issue Nov 5, 2019 · 8 comments
Closed

feature: minikube should not crash if service or namespace doesn't exist. #5836

bjkowalski opened this issue Nov 5, 2019 · 8 comments
Assignees
@rajula96reddy
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/ux lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@bjkowalski
Copy link

I am running minikube version v1.5.2.

I discovered that if I specify an undefined "namespace" with the namespace option on the service command an error is reported but there is also a message that says "mini9kube crashed".

The exact command to reproduce the issue:
minikube service newservice -n unknown --url

The full output of the command that failed:


$ minikube service newservice -n unknown --url

💣 Error opening service: Service newservice was not found in "unknown" namespace. You may select another namespace by using 'minikube service newservice -n : Temporary Error: Error getting service newservice: services "newservice" not found

😿 Sorry that minikube crashed. If this was unexpected, we would love to hear from you:
👉 https://github.com/kubernetes/minikube/issues/new/choose

The output of the minikube logs command:


minikube.log

The operating system version:
Linux bj-XPS-13-9360 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
@medyagh
Copy link
Member

medyagh commented Nov 6, 2019 •
edited
Loading

ah ! thanks for reporting it !

I see that we have a nicely worded error message however it is not acceptable that we Crash !
you are right !

we should exit without crashing with a nice message that the service doesnt exist.
this should be an easy fix, I would be happy to review any PR that fixes this !

I also noticed when the service doesn't exist it is painfully slow and takes a lot of time to get back to you. I bet this might be a Retry Logic, that we could make it less time consuming.

the Fix should also tell the users, to see list of all services use this command:

minikube service list

@medyagh medyagh added needs-solution-message Issues where where offering a solution for an error would be helpful good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/ux labels Nov 6, 2019
@medyagh medyagh changed the title Accessing undefined namespace generates "minikube crashed" error message feature: minikube should not crash if service or namespace doesn't exist. Nov 6, 2019
@medyagh medyagh added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 6, 2019
@rajula96reddy
Copy link
Member

/assign @rajula96reddy

@rajula96reddy rajula96reddy mentioned this issue Nov 6, 2019
Merged
@tstromberg tstromberg added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Dec 9, 2019
@medyagh
Copy link
Member

medyagh commented Dec 17, 2019

@rajula96reddy are you still working on it ?

@rajula96reddy
Copy link
Member

@medyagh Yeah! I am working on it and I am gonna finish this soon. Probably today or tomorrow. I am really sorry, I got stuck with some stuff and couldn't finish it earlier.

@tstromberg tstromberg removed the needs-solution-message Issues where where offering a solution for an error would be helpful label Dec 19, 2019
@tstromberg tstromberg mentioned this issue Dec 20, 2019
Merged
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 18, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 17, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rajula96reddy rajula96reddy

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/ux lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@tstromberg @medyagh @rajula96reddy @k8s-ci-robot @fejta-bot @bjkowalski