Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Ignoring --vm-driver" warning #4998

Closed
tstromberg opened this issue Aug 6, 2019 · 3 comments · Fixed by #5016
Closed

Remove "Ignoring --vm-driver" warning #4998

tstromberg opened this issue Aug 6, 2019 · 3 comments · Fixed by #5016
Assignees
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@tstromberg
Copy link
Contributor

Related to #4855 and #4614

This warning is noisy and is always doing the wrong thing. It's raised in two scenarios:

1. User has an existing non-virtualbox VM and runs minikube start - sees warning.

The user has not specified a --vm-driver here. We should quietly do what the user wants and resume their existing VM.

2. User has specified an existing VM, and runs minikube start --vm-driver=xxx

The user has explicitly specified a VM driver. We should error and exit, rather than ignoring their request.

Implementation wise, the most obvious way to do this is change the default driver to auto. If they have an existing config, the automatic default is to use that driver. If not, we can stick with virtualbox and build toward "best available".

@tstromberg tstromberg added this to the v1.4.0 Candidate milestone Aug 6, 2019
@tstromberg tstromberg added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Aug 6, 2019
@RA489
Copy link

RA489 commented Aug 7, 2019

/assign @RA489

@tstromberg
Copy link
Contributor Author

@RA489 - Will this issue be resolved in time for v1.4.0 (Sep 16?)

@RA489
Copy link

RA489 commented Sep 4, 2019

@tstromberg yeah, sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants