Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: reduce repetitive icon for same warning (if using existing driver) #4855

Closed
medyagh opened this issue Jul 23, 2019 · 14 comments
Closed

UI: reduce repetitive icon for same warning (if using existing driver) #4855

medyagh opened this issue Jul 23, 2019 · 14 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. sig/ui Categorizes an issue or PR as relevant to SIG UI.

Comments

@medyagh
Copy link
Member

medyagh commented Jul 23, 2019

Currently it shows as :

$ ./out/minikube start 
😄  minikube v1.2.0 on darwin (amd64)


⚠️  Ignoring --vm-driver=virtualbox, as the existing "delete" VM was created using the hyperkit driver.
⚠️  To switch drivers, you may create a new VM using `minikube start -p <name> --vm-driver=virtualbox`
⚠️  Alternatively, you may delete the existing VM using `minikube delete -p delete`


🏃  Re-using the currently running hyperkit VM for "delete" ...
⌛  Waiting for SSH access ...
🐳  Configuring environment for Kubernetes v1.15.0 on Docker 18.09.6
🔄  Relaunching Kubernetes v1.15.0 using kubeadm ... 
⌛  Verifying: apiserver proxy etcd scheduler controller dns
🏄  Done! kubectl is now configured to use delete

there is no need for 3 warning signs, one is enough as it is related to same warning.

@medyagh medyagh added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. sig/ui Categorizes an issue or PR as relevant to SIG UI. labels Jul 23, 2019
@RA489
Copy link

RA489 commented Jul 24, 2019

@medyagh I think if we can combine these two warnings to one. WDYT?
⚠️ Ignoring --vm-driver=virtualbox, as the existing "delete" VM was created using the hyperkit driver.
⚠️ To switch drivers, you may create a new VM using minikube start -p <name> --vm-driver=virtualbox

@RA489
Copy link

RA489 commented Jul 24, 2019

⚠️ Alternatively, you may delete the existing VM using minikube delete -p delete
@medyagh we can ignore this warning! suggestions?

@RA489
Copy link

RA489 commented Jul 24, 2019

/assign @RA489

@afbjorklund
Copy link
Collaborator

afbjorklund commented Jul 25, 2019

I think that we need all three, there seem to be a lot of people struggling with this ?

They want to use Hyper-V, they forget to tell Minikube. So they create half a VirtualBox one,
and then it is in the way when eventually switching to Hyper-V. Thus, they need to delete it...

Then again, the main problem seems to be people not reading anything, before "start".

@RA489
Copy link

RA489 commented Jul 25, 2019

@afbjorklund I agree +1 in that case we can close this issue.

@RA489
Copy link

RA489 commented Jul 25, 2019

@medyagh can we close this issue as per @afbjorklund comments. wdyt?

@afbjorklund
Copy link
Collaborator

I think the better fix would be something similar to #4846, to use the "right" VM driver in the first place ?

And maybe we should recommend minikube config set vm-driver, so that minikube start "works" ?

@medyagh
Copy link
Member Author

medyagh commented Jul 25, 2019

the issue I created this for was the number of Warning Icons, I agree with the message but I think there should be only one Warning Icon
and the second and third line should have empty icon.

I also like the idea of advising them to set it through
minikube config set vm-driver

@afbjorklund
Copy link
Collaborator

Ah, OK - so it was more of a UX thing. Thought you meant the actual context ;-)

Maybe there should one BIG icon (as per #3724), that should get their attention!

@afbjorklund
Copy link
Collaborator

afbjorklund commented Jul 25, 2019

A "preflight" might also be a good idea

 __                 
/  \        _______________ 
|  |       /               \
@  @       | It looks      |
|| ||      | like you      |
|| ||   <--| are starting  |
|\_/|      | a hypervisor. |
\___/      \_______________/

@medyagh medyagh changed the title better warning if using existing driver reduce repetitive icon for same warning (if using existing driver) Jul 25, 2019
@medyagh medyagh changed the title reduce repetitive icon for same warning (if using existing driver) UI: reduce repetitive icon for same warning (if using existing driver) Jul 25, 2019
@medyagh
Copy link
Member Author

medyagh commented Jul 25, 2019

A "preflight" might also be a good idea

 __                 
/  \        _______________ 
|  |       /               \
@  @       | It looks      |
|| ||      | like you      |
|| ||   <--| are starting  |
|\_/|      | a hypervisor. |
\___/      \_______________/

I actually like that better than Warning ! because I see this message myself a lot, and I dont like minikube showing warning icon to me, for a normal thing I do a lot ! I am down for an ASCI art like you did.

and also I like Anders suggestion to advice the user to Config Set it. anyone who wants to pick this issue up, I recommend having an indented UI for this. so they know this is all related to this one situation.

@blueelvis
Copy link
Contributor

Just FYI, by default on Windows, emoji's are not displayed on PowerShell. There is a workaround for enabling unicode support IMO.

-Pranav

@afbjorklund
Copy link
Collaborator

afbjorklund commented Jul 25, 2019

@medyagh sorry for hijacking your issue

📎 Should make sure to label jokes

What I actually meant was:

https://kubernetes.io/docs/tasks/tools/install-minikube/#before-you-begin

@tstromberg
Copy link
Contributor

Closing as we've decided to get rid of this warning altogether (#4998)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. sig/ui Categorizes an issue or PR as relevant to SIG UI.
Projects
None yet
Development

No branches or pull requests

5 participants