-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: reduce repetitive icon for same warning (if using existing driver) #4855
Comments
@medyagh I think if we can combine these two warnings to one. WDYT? |
|
/assign @RA489 |
I think that we need all three, there seem to be a lot of people struggling with this ? They want to use Hyper-V, they forget to tell Minikube. So they create half a VirtualBox one, Then again, the main problem seems to be people not reading anything, before "start". |
@afbjorklund I agree +1 in that case we can close this issue. |
@medyagh can we close this issue as per @afbjorklund comments. wdyt? |
I think the better fix would be something similar to #4846, to use the "right" VM driver in the first place ? And maybe we should recommend |
the issue I created this for was the number of Warning Icons, I agree with the message but I think there should be only one Warning Icon I also like the idea of advising them to set it through |
Ah, OK - so it was more of a UX thing. Thought you meant the actual context ;-) Maybe there should one BIG icon (as per |
A "preflight" might also be a good idea
|
I actually like that better than Warning ! because I see this message myself a lot, and I dont like minikube showing warning icon to me, for a normal thing I do a lot ! I am down for an ASCI art like you did. and also I like Anders suggestion to advice the user to Config Set it. anyone who wants to pick this issue up, I recommend having an indented UI for this. so they know this is all related to this one situation. |
Just FYI, by default on Windows, emoji's are not displayed on PowerShell. There is a workaround for enabling unicode support IMO. -Pranav |
@medyagh sorry for hijacking your issue 📎 Should make sure to label jokes What I actually meant was: https://kubernetes.io/docs/tasks/tools/install-minikube/#before-you-begin |
Closing as we've decided to get rid of this warning altogether (#4998) |
Currently it shows as :
there is no need for 3 warning signs, one is enough as it is related to same warning.
The text was updated successfully, but these errors were encountered: